Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751856AbdISRsZ (ORCPT ); Tue, 19 Sep 2017 13:48:25 -0400 Received: from mail-wr0-f170.google.com ([209.85.128.170]:48463 "EHLO mail-wr0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751646AbdISRsW (ORCPT ); Tue, 19 Sep 2017 13:48:22 -0400 X-Google-Smtp-Source: AOwi7QBbd2T0nZk0RCBTANbhhmtzHgD79ctX4iIoWW9oLE9hEwqsFSai51q1cVhQycv/Ay+6gFwfSw== Subject: Re: [PATCH net-next 2/4] net: dsa: setup master ethtool unconditionally To: Vivien Didelot , netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Andrew Lunn References: <20170919155700.14474-1-vivien.didelot@savoirfairelinux.com> <20170919155700.14474-3-vivien.didelot@savoirfairelinux.com> From: Florian Fainelli Message-ID: Date: Tue, 19 Sep 2017 10:48:17 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170919155700.14474-3-vivien.didelot@savoirfairelinux.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 371 Lines: 11 On 09/19/2017 08:56 AM, Vivien Didelot wrote: > When a DSA switch tree is meant to be applied, it already has a CPU > port. Thus remove the condition of dst->cpu_dp. > > Moreover, the next lines access dst->cpu_dp unconditionally. > > Signed-off-by: Vivien Didelot Reviewed-by: Florian Fainelli -- Florian