Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S268851AbTGJDQz (ORCPT ); Wed, 9 Jul 2003 23:16:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S268864AbTGJDQz (ORCPT ); Wed, 9 Jul 2003 23:16:55 -0400 Received: from perninha.conectiva.com.br ([200.250.58.156]:8926 "EHLO perninha.conectiva.com.br") by vger.kernel.org with ESMTP id S268851AbTGJDQw (ORCPT ); Wed, 9 Jul 2003 23:16:52 -0400 Date: Thu, 10 Jul 2003 00:29:06 -0300 (BRT) From: Marcelo Tosatti X-X-Sender: marcelo@freak.distro.conectiva To: "J.A. Magallon" Cc: lkml Subject: Re: [PATCH] do_generic_direct_write: bad flag check In-Reply-To: <20030709231348.GC18564@werewolf.able.es> Message-ID: References: <20030709231348.GC18564@werewolf.able.es> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 853 Lines: 32 On Thu, 10 Jul 2003, J.A. Magallon wrote: > > On 07.10, Marcelo Tosatti wrote: > > > > Hi, > > > > Here goes -pre4. It contains a lot of updates and fixes. > > > > --- linux-2.4.22-pre2-jam1/mm/filemap.c.orig 2003-06-28 01:55:36.000000000 +0200 > +++ linux-2.4.22-pre2-jam1/mm/filemap.c 2003-06-28 01:55:45.000000000 +0200 > @@ -3223,7 +3223,7 @@ > if (err != 0 || count == 0) > goto out; > > - if (!file->f_flags & O_DIRECT) > + if (!(file->f_flags & O_DIRECT)) > BUG(); > > remove_suid(inode); > > ...but sure the fix in -ac is better. What is the difference between the fix in -ac and yours? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/