Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751794AbdISUNA convert rfc822-to-8bit (ORCPT ); Tue, 19 Sep 2017 16:13:00 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:51571 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751445AbdISUM7 (ORCPT ); Tue, 19 Sep 2017 16:12:59 -0400 Date: Tue, 19 Sep 2017 22:12:46 +0200 From: Boris Brezillon To: Corentin Labbe Cc: richard@nod.at, dwmw2@infradead.org, computersforpeace@gmail.com, marek.vasut@gmail.com, cyrille.pitchen@wedev4u.fr, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mtd: nand: remove unused blockmask variable Message-ID: <20170919221246.4e46cb9e@bbrezillon> In-Reply-To: <20170902084938.15942-1-clabbe.montjoie@gmail.com> References: <20170902084938.15942-1-clabbe.montjoie@gmail.com> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1399 Lines: 39 On Sat, 2 Sep 2017 10:49:38 +0200 Corentin Labbe wrote: > This patch fix the following build warning: > drivers/mtd/nand/nand_base.c:2671:30: attention : variable ‘blockmask’ set but not used [-Wunused-but-set-variable] Applied. Thanks, Boris > > Signed-off-by: Corentin Labbe > --- > drivers/mtd/nand/nand_base.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c > index 9900476a0afe..b875fd365084 100644 > --- a/drivers/mtd/nand/nand_base.c > +++ b/drivers/mtd/nand/nand_base.c > @@ -2668,7 +2668,7 @@ static uint8_t *nand_fill_oob(struct mtd_info *mtd, uint8_t *oob, size_t len, > static int nand_do_write_ops(struct mtd_info *mtd, loff_t to, > struct mtd_oob_ops *ops) > { > - int chipnr, realpage, page, blockmask, column; > + int chipnr, realpage, page, column; > struct nand_chip *chip = mtd_to_nand(mtd); > uint32_t writelen = ops->len; > > @@ -2704,7 +2704,6 @@ static int nand_do_write_ops(struct mtd_info *mtd, loff_t to, > > realpage = (int)(to >> chip->page_shift); > page = realpage & chip->pagemask; > - blockmask = (1 << (chip->phys_erase_shift - chip->page_shift)) - 1; > > /* Invalidate the page cache, when we write to the cached page */ > if (to <= ((loff_t)chip->pagebuf << chip->page_shift) &&