Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751556AbdISVKt (ORCPT ); Tue, 19 Sep 2017 17:10:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:53786 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751237AbdISVKs (ORCPT ); Tue, 19 Sep 2017 17:10:48 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 687A921D28 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=robh+dt@kernel.org X-Google-Smtp-Source: AOwi7QDWURWm1XCnBPa8f9FhEkqvGWDQgpR+37kx8YJrPg0lwg2/T78QY6NxnUA4uROlG6TdTmoCVoAFTTdxfTp8UYk= MIME-Version: 1.0 In-Reply-To: <830b4d20-26e2-02ce-76db-b63c73967e39@ti.com> References: <20170918205005.30235-1-afd@ti.com> <20170918205005.30235-2-afd@ti.com> <830b4d20-26e2-02ce-76db-b63c73967e39@ti.com> From: Rob Herring Date: Tue, 19 Sep 2017 16:10:25 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/2] tee: optee: allow selection of ti-smc as a calling method To: "Andrew F. Davis" Cc: Mark Rutland , Russell King , Jens Wiklander , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1661 Lines: 35 On Tue, Sep 19, 2017 at 10:54 AM, Andrew F. Davis wrote: > On 09/19/2017 08:36 AM, Rob Herring wrote: >> On Mon, Sep 18, 2017 at 3:50 PM, Andrew F. Davis wrote: >>> On TI platforms OP-TEE must be called using a modified SMC call, >>> allow the selection of this though DT. >>> >>> Signed-off-by: Andrew F. Davis >>> --- >>> Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.txt | 2 ++ >>> drivers/tee/optee/core.c | 2 ++ >>> 2 files changed, 4 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.txt b/Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.txt >>> index d38834c67dff..a3275ecdf186 100644 >>> --- a/Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.txt >>> +++ b/Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.txt >>> @@ -20,6 +20,8 @@ the reference implementation maintained by Linaro. >>> "hvc" : HVC #0, with the register assignments specified >>> in drivers/tee/optee/optee_smc.h >>> >>> + "ti-smc" : Similar to "smc" with TI specific register >>> + adjustments >> >> Sigh, really? IMO, this should be determined from the compatible >> string. Then the next TI (or any vendor) specific thing can be handled >> without a DT change. >> > > Which compatible string, do you mean the OP-TEE driver check the top > level platform compatible string? No, you need to have something like "ti,optee-tz" for the driver to match on because your implementation is different. Rob