Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751743AbdISXEk (ORCPT ); Tue, 19 Sep 2017 19:04:40 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:49968 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751575AbdISXEj (ORCPT ); Tue, 19 Sep 2017 19:04:39 -0400 Date: Tue, 19 Sep 2017 16:04:38 -0700 (PDT) Message-Id: <20170919.160438.114096071481057977.davem@davemloft.net> To: f.fainelli@gmail.com Cc: vivien.didelot@savoirfairelinux.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, andrew@lunn.ch Subject: Re: [PATCH net-next 0/4] net: dsa: move master ethtool code From: David Miller In-Reply-To: <80b8afa0-e269-c0b7-da4a-dcb604a239ca@gmail.com> References: <20170919155700.14474-1-vivien.didelot@savoirfairelinux.com> <80b8afa0-e269-c0b7-da4a-dcb604a239ca@gmail.com> X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 19 Sep 2017 16:04:39 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1154 Lines: 27 From: Florian Fainelli Date: Tue, 19 Sep 2017 13:04:56 -0700 > On 09/19/2017 08:56 AM, Vivien Didelot wrote: >> The DSA core overrides the master device's ethtool_ops structure so that >> it can inject statistics and such of its dedicated switch CPU port. >> >> This ethtool code is currently called on unnecessary conditions or >> before the master interface and its switch CPU port get wired up. >> This patchset fixes this. >> >> Similarly to slave.c where the DSA slave net_device is the entry point >> of the dsa_slave_* functions, this patchset also isolates the master's >> ethtool code in a new master.c file, where the DSA master net_device is >> the entry point of the dsa_master_* functions. >> >> This is a first step towards better control of the master device and >> support for multiple CPU ports. > > Tested-by: Florian Fainelli > > * ethtool -S eth0 -> switch port CPU stats are still correctly overlayed > * ethtool -s gphy wol g -> both switch port and CPU port correctly > enable WoL > * ethtool -i eth0 -> driver still reports correct information Series applied, thanks everyone.