Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751813AbdISXKL (ORCPT ); Tue, 19 Sep 2017 19:10:11 -0400 Received: from mail-pg0-f54.google.com ([74.125.83.54]:48583 "EHLO mail-pg0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751614AbdISXKJ (ORCPT ); Tue, 19 Sep 2017 19:10:09 -0400 X-Google-Smtp-Source: AOwi7QDnrhSmHNNIKrh1GLi9knlJ2kBCFTf5nl+F+eLGTmlexIj7Ef1Bhq78iCn9kAuOsD7L+SQXJQ== Date: Tue, 19 Sep 2017 16:10:07 -0700 From: Viresh Kumar To: Dong Aisheng Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, sboyd@codeaurora.org, vireshk@kernel.org, nm@ti.com, rjw@rjwysocki.net, shawnguo@kernel.org, Anson.Huang@nxp.com, ping.bai@nxp.com Subject: Re: [PATCH 6/7] cpufreq: make cpufreq_generic_init transition_latency default to CPUFREQ_ETERNAL Message-ID: <20170919231007.GJ30848@ubuntu> References: <1503504610-12880-1-git-send-email-aisheng.dong@nxp.com> <1503504610-12880-7-git-send-email-aisheng.dong@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1503504610-12880-7-git-send-email-aisheng.dong@nxp.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1294 Lines: 38 On 24-08-17, 00:10, Dong Aisheng wrote: > If no valid transition_latency specified, let's make it default to > CPUFREQ_ETERNAL which is consistent with its definition. > > This can save some of the same checkings like this: > transition_latency = dev_pm_opp_get_max_transition_latency(cpu_dev); > - if (!transition_latency) > - transition_latency = CPUFREQ_ETERNAL; > ret = cpufreq_generic_init(policy, freq_table, transition_latency); > > Cc: Viresh Kumar > Cc: Nishanth Menon > Cc: Stephen Boyd > Cc: "Rafael J. Wysocki" > Signed-off-by: Dong Aisheng > --- > drivers/cpufreq/cpufreq.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c > index 9bf97a3..da07de6 100644 > --- a/drivers/cpufreq/cpufreq.c > +++ b/drivers/cpufreq/cpufreq.c > @@ -180,6 +180,8 @@ int cpufreq_generic_init(struct cpufreq_policy *policy, > return ret; > } > > + if (!transition_latency) > + transition_latency = CPUFREQ_ETERNAL; > policy->cpuinfo.transition_latency = transition_latency; > > /* Can you update all the existing drivers as well (in the same patch) who can benefit from it? -- viresh