Subject: Re: Regression in virtio block driver with 4.13.2
To: Christoph Hellwig <hch@infradead.org>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
        Jason Wang <jasowang@redhat.com>,
        virtualization@lists.linux-foundation.org,
        linux-kernel@vger.kernel.org
References: <93e65aef-e93d-6a99-854a-f6147f84e3b1@redhat.com>
 <20170915173703.GA23073@infradead.org>
 <db314009-f47f-17bc-e2d6-d84936432575@redhat.com>
 <20170917235731.GA31789@infradead.org>
From: Laura Abbott <labbott@redhat.com>
Message-ID: <227487f8-3b7a-a431-da32-890f4a73732b@redhat.com>
Date: Tue, 19 Sep 2017 17:15:47 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.0
MIME-Version: 1.0
In-Reply-To: <20170917235731.GA31789@infradead.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 689
Lines: 18

On 09/17/2017 04:57 PM, Christoph Hellwig wrote:
> On Sat, Sep 16, 2017 at 04:16:06PM -0700, Laura Abbott wrote:
>> Yes, the issue goes  away when CONFIG_VIRTIO_BLK_SCSI is
>> disabled.
> 
> Ok, so it's probably related to follow ups to the scsi_request split.
> 
> That being said, I would highly recommend turning off
> CONFIG_VIRTIO_BLK_SCSI in fedora.  The feature has caused more trouble
> than it helped with, and should never have been added (saying that as
> the person who added it). It was never supported with virtio 1.0 devices
> and has been disabled in qemu by default for quite a while.
> 

Thanks for the pointer, I went and turned it off on our 4.13 based
kernels.

Laura