Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751619AbdITBDE (ORCPT ); Tue, 19 Sep 2017 21:03:04 -0400 Received: from mailout.easymail.ca ([64.68.200.34]:51807 "EHLO mailout.easymail.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751506AbdITBDD (ORCPT ); Tue, 19 Sep 2017 21:03:03 -0400 Reply-To: shuah@kernel.org Subject: Re: [tip:timers/core] kselftests: timers: set-timer-lat: Tweak reporting when timer fires early To: linux-kernel@vger.kernel.org, richardcochran@gmail.com, hpa@zytor.com, tglx@linutronix.de, mingo@kernel.org, john.stultz@linaro.org, prarit@redhat.com, stephen.boyd@linaro.org, ghackmann@google.com, mlichvar@redhat.com, linux-tip-commits@vger.kernel.org, Shuah Khan References: Cc: Shuah Khan From: Shuah Khan Message-ID: <04d5e9e4-ef81-a9e7-8180-2c668e3af9d0@kernel.org> Date: Tue, 19 Sep 2017 19:02:41 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2047 Lines: 52 Hi Greg, On 08/20/2017 03:56 AM, tip-bot for Greg Hackmann wrote: > Commit-ID: a524b1184b8e86141d689fa78ad150fbf2db9b4c > Gitweb: http://git.kernel.org/tip/a524b1184b8e86141d689fa78ad150fbf2db9b4c > Author: Greg Hackmann > AuthorDate: Tue, 25 Jul 2017 14:36:25 -0700 > Committer: John Stultz > CommitDate: Thu, 17 Aug 2017 12:14:54 -0700 > > kselftests: timers: set-timer-lat: Tweak reporting when timer fires early > > Rather than printing an error inside the alarm signal handler, set a > flag that we check later. This keeps the test from spamming the console > every time the alarm fires early. It also fixes the test exiting with > error code 0 if this was the only test failure. > > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: Miroslav Lichvar > Cc: Richard Cochran > Cc: Prarit Bhargava > Cc: Stephen Boyd > Cc: Shuah Khan > Cc: linux-kselftest@vger.kernel.org > Signed-off-by: Greg Hackmann > Signed-off-by: John Stultz This commit is making the set-timer-lat hang. I reverted this commit and there is no hang. Could you please take a look and see if this commit should be reverted. make kselftest as well as make -C tools/testing/selftests/timers run_tests hang. I had to revert the following as well, however a524b1184b8e86141d689fa78ad150fbf2db9b4c is the suspect. Commit-ID: 28be3f8f48cfb3cf024860f042d424cd4824f5f7 Gitweb: http://git.kernel.org/tip/28be3f8f48cfb3cf024860f042d424cd4824f5f7 Author: Greg Hackmann AuthorDate: Tue, 25 Jul 2017 14:36:26 -0700 Committer: John Stultz CommitDate: Thu, 17 Aug 2017 12:14:58 -0700 kselftests: timers: set-timer-lat: Add one-shot timer test cases Please let me know how you want to proceed. At the moment kselftest run hangs due this test hang. thanks, -- Shuah