Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751609AbdITDVe (ORCPT ); Tue, 19 Sep 2017 23:21:34 -0400 Received: from mail-wr0-f177.google.com ([209.85.128.177]:53329 "EHLO mail-wr0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751283AbdITDVb (ORCPT ); Tue, 19 Sep 2017 23:21:31 -0400 X-Google-Smtp-Source: AOwi7QDQT+WM3aG477qy/s9hLvsDGoL0X0xcPiTsanKFvufJBLVhvuIbxUK6kvqaQD5hoiUXhI5oU2ur3dD1DUjZ+4w= MIME-Version: 1.0 In-Reply-To: <04d5e9e4-ef81-a9e7-8180-2c668e3af9d0@kernel.org> References: <04d5e9e4-ef81-a9e7-8180-2c668e3af9d0@kernel.org> From: John Stultz Date: Tue, 19 Sep 2017 20:21:29 -0700 Message-ID: Subject: Re: [tip:timers/core] kselftests: timers: set-timer-lat: Tweak reporting when timer fires early To: Shuah Khan Cc: lkml , Richard Cochran , "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , Prarit Bhargava , Stephen Boyd , Greg Hackmann , Miroslav Lichvar , linux-tip-commits@vger.kernel.org, Shuah Khan Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2291 Lines: 56 On Tue, Sep 19, 2017 at 6:02 PM, Shuah Khan wrote: > Hi Greg, > > On 08/20/2017 03:56 AM, tip-bot for Greg Hackmann wrote: >> Commit-ID: a524b1184b8e86141d689fa78ad150fbf2db9b4c >> Gitweb: http://git.kernel.org/tip/a524b1184b8e86141d689fa78ad150fbf2db9b4c >> Author: Greg Hackmann >> AuthorDate: Tue, 25 Jul 2017 14:36:25 -0700 >> Committer: John Stultz >> CommitDate: Thu, 17 Aug 2017 12:14:54 -0700 >> >> kselftests: timers: set-timer-lat: Tweak reporting when timer fires early >> >> Rather than printing an error inside the alarm signal handler, set a >> flag that we check later. This keeps the test from spamming the console >> every time the alarm fires early. It also fixes the test exiting with >> error code 0 if this was the only test failure. >> >> Cc: Thomas Gleixner >> Cc: Ingo Molnar >> Cc: Miroslav Lichvar >> Cc: Richard Cochran >> Cc: Prarit Bhargava >> Cc: Stephen Boyd >> Cc: Shuah Khan >> Cc: linux-kselftest@vger.kernel.org >> Signed-off-by: Greg Hackmann >> Signed-off-by: John Stultz > > This commit is making the set-timer-lat hang. I reverted this commit > and there is no hang. Could you please take a look and see if this > commit should be reverted. > > make kselftest as well as make -C tools/testing/selftests/timers run_tests > hang. > > I had to revert the following as well, however a524b1184b8e86141d689fa78ad150fbf2db9b4c > is the suspect. > > Commit-ID: 28be3f8f48cfb3cf024860f042d424cd4824f5f7 > Gitweb: http://git.kernel.org/tip/28be3f8f48cfb3cf024860f042d424cd4824f5f7 > Author: Greg Hackmann > AuthorDate: Tue, 25 Jul 2017 14:36:26 -0700 > Committer: John Stultz > CommitDate: Thu, 17 Aug 2017 12:14:58 -0700 > > kselftests: timers: set-timer-lat: Add one-shot timer test cases > > Please let me know how you want to proceed. At the moment kselftest > run hangs due this test hang. Huh. I didn't see such a hang in my testing. Let me try to reproduce and see if I can figure out whats going on. thanks -john