Date: Wed, 20 Sep 2017 08:34:00 +0200 (CEST)
From: Julia Lawall <julia.lawall@lip6.fr>
To: Michael Ellerman <mpe@ellerman.id.au>
cc: Bhumika Goyal <bhumirks@gmail.com>, benh@kernel.crashing.org,
        paulus@samba.org, linuxppc-dev@lists.ozlabs.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc: make irq_chip const, __initdata and
 __initconst
In-Reply-To: <87o9q5lwgq.fsf@concordia.ellerman.id.au>
Message-ID: <alpine.DEB.2.20.1709200833320.4638@hadrien>
References: <1505743967-19448-1-git-send-email-bhumirks@gmail.com> <87o9q5lwgq.fsf@concordia.ellerman.id.au>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 634
Lines: 22


On Wed, 20 Sep 2017, Michael Ellerman wrote:

> Bhumika Goyal <bhumirks@gmail.com> writes:
>
> > Make ehv_pic_irq_chip, mpic_ipi_chip and mpic_tm_chip const as they are
> > used only as a copy operation. This usage is during init, so make them
> > __initconst too.
> > Make mpic_ipi_chip __initdata as it is only modified during the init
> > phase and there is no reference of it anywhere after init.
>
> The change log doesn't seem to match the code.
>
> It's mpic_tm_chip which you marked __initdata, and that looks wrong, as
> we keep a pointer to it here:
>
> 	mpic->hc_tm = mpic_tm_chip;

This looks like a memory copy.

julia