Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751653AbdITGho (ORCPT ); Wed, 20 Sep 2017 02:37:44 -0400 Received: from mail-pf0-f175.google.com ([209.85.192.175]:49344 "EHLO mail-pf0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751175AbdITGhm (ORCPT ); Wed, 20 Sep 2017 02:37:42 -0400 X-Google-Smtp-Source: AOwi7QA888LmL3HUhfJuJosjN10OUhpgQHWKHoyJork2pcrH5aorxjB08f69uEviABbIOomsnCtkPQ== Date: Tue, 19 Sep 2017 23:37:38 -0700 From: Benson Leung To: Dmitry Torokhov Cc: Jiri Kosina , Benjamin Tissoires , Benson Leung , Oliver Neukum , Guenter Roeck , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] HID: hidraw: fix power sequence when closing device Message-ID: <20170920063738.GA153422@decatoncale.mtv.corp.google.com> References: <20170920013746.GA33367@dtor-ws> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="liOOAslEiF7prFVr" Content-Disposition: inline In-Reply-To: <20170920013746.GA33367@dtor-ws> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1623 Lines: 49 --liOOAslEiF7prFVr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Dmitry, On Tue, Sep 19, 2017 at 06:37:46PM -0700, Dmitry Torokhov wrote: > We should not try to bring HID device out of full power state before > calling hid_hw_close(), so that transport driver operates on powered up > device (making this inverse of the opening sequence). >=20 > Signed-off-by: Dmitry Torokhov Reviewed-by: Benson Leung --=20 Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. bleung@google.com Chromium OS Project bleung@chromium.org --liOOAslEiF7prFVr Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJZwgyyAAoJEB8J9XsKL+ZYO+4P/1joB2LbFoc9hoGgDz/rJoGb ZuRehmMpz3ueWoxxcZCJAa/mybAD/8zLP7h/R5lu0n6I6HnRp2ERNndJGGpJtrg1 KTQd8JFOMQJdo4nyrVwUp2AoR0ek/+G4yLpBfI+nUg1W5kPpNnkcknveCMQDKj1u bIkNATMLg/YgCAJc6eW4XJkudNbY0ULFf+dOjOyhTzQ4HYsLXdaiZXqp0aoV8a/X 5nza3psEuyobC3hOZbuMu4K9DQwYbnvS6oPhxkmo+akpOF34Y9z0kXvScwBTUF73 WiNiTC109RCQkZaYEGlJfPWbmyd4zSgh0IpxUFI5ajs+E1rNLtNCUB4DquA3y3WM EcU5lQzw9K9v1/pW7zrobYdOyOiaRm+Fup/thiU3fq6mpTbUAKtmjzoKvCNi7XOo O65Hpie/pwGQ2CS1EEYhQxkOx5ODfdUS3TcoMZ6/NN7f4wnXC05hcOKTnoTaObff rxkGNaGDbhcP2aLdH1LsJpR0wkrJK7Qf5AZybZjNoK4GQ2F/NBrbTrqMRNuxjXB0 b2/PJGIH++j9U/wQdzuI5s4wnhzV5YcdNJit5qwHA05GCKNDFIUXQUH1Jea8CojX AqVqMo+d0AsLOreIQfNYnvNV3TTnlU6y5h4PfcEj6ZcyU2J4YSO+MF7ZBnJzW8mm VVrDqxCcBeVv3RJJM1Sa =1NLR -----END PGP SIGNATURE----- --liOOAslEiF7prFVr--