Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751802AbdITG6R (ORCPT ); Wed, 20 Sep 2017 02:58:17 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:44898 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751782AbdITG6P (ORCPT ); Wed, 20 Sep 2017 02:58:15 -0400 Date: Wed, 20 Sep 2017 08:58:14 +0200 From: Maxime Ripard To: Corentin Labbe Cc: vinod.koul@intel.com, dan.j.williams@intel.com, wens@csie.org, dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dmaengine: sun6i: sun4i-gpadc: use of_device_get_match_data Message-ID: <20170920065814.fle73gxbu3oyqsr4@flea.home> References: <20170919184447.4479-1-clabbe.montjoie@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="bh6sg4lyhw2bhacb" Content-Disposition: inline In-Reply-To: <20170919184447.4479-1-clabbe.montjoie@gmail.com> User-Agent: NeoMutt/20170914 (1.9.0) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1587 Lines: 48 --bh6sg4lyhw2bhacb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Tue, Sep 19, 2017 at 06:44:47PM +0000, Corentin Labbe wrote: > The usage of of_device_get_match_data reduce the code size a bit. > Furthermore, it prevents an improbable dereference when > of_match_device() return NULL. >=20 > Signed-off-by: Corentin Labbe The prefix of your commit title is wrong, this isn't about the GPADC. Once fixed, Acked-by: Maxime Ripard Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --bh6sg4lyhw2bhacb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBAgAGBQJZwhGGAAoJEBx+YmzsjxAgfP4P/i7vMgiIm2QpEPch8oGpTypt kIfgzEgWEqyzKFjSbnZmRJo6KR5shzsA7btwT2Yv4REl+zLl3YqqzrDoWFYCOLf8 sOUdK+PmuZeSrlfBeN3Aqn755pjAo5eaexDHxLJxC9k4q+wTe5dWE9fuuiaOwQKJ S5EAuXF6F/ts6d7F5ZP8Ki2ib+ChfQIkySnbV28H1nwGzG7+Yru+zyeY8DNViXZr lUHUpa3dgKP7UHNv1ShbbX6dRF9HMqkYdCtpLE+ty7xy/F3Q4KYOHPJ+FLDj0iSH 1AqR3mh6tl9SLlo/7DbaxwOuFqpKDf3s7DgHjFLbblMA4J+4zNJjF6m1WlqJrDE9 tYMSB9la8KESqUALjaJoxgp+XjtH3YQKHeVLVS+eE6gqZx9yU/4So8+dzSywsf/u 57wQFAdnpy+i5lvNa60rsbXNKRNKREgDXaVOxKyVujX9hERBecsHK6dxCWyU6XrZ V6LsWA5HmlQIlheFyEA/GNt0K9W8lWzTh9zAB+Bgy2/vcQqIeuq7SoaxuWCm769N nIDIlgRLepEtFOGP5COIGQmhLzsk3D5NiGq9TuWSYFrpeOur/vaQy1p5S47+nt2O AfkMDcbVIU1Jc5cVV10IS4pv+5/jYTeZl7caQo9IRnGUenUtVdB0lSdOOj9HuHTE AmgtPHHmMSX7f5QXuQ3t =47Kv -----END PGP SIGNATURE----- --bh6sg4lyhw2bhacb--