Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751832AbdITHOQ (ORCPT ); Wed, 20 Sep 2017 03:14:16 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:35438 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751771AbdITHOO (ORCPT ); Wed, 20 Sep 2017 03:14:14 -0400 X-Google-Smtp-Source: AOwi7QBGQUork/IHRZDkM62UFBdpIgsceJ9Ta+MSHIotRUyVrsaZQa17+RuQr+wQpBO3fmebv/jjPA== From: Arvind Yadav To: gregory.0xf0@gmail.com, linus.walleij@linaro.org, computersforpeace@gmail.com, f.fainelli@gmail.com Cc: bcm-kernel-feedback-list@broadcom.com, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] gpio: tb10x: Handle return value of devm_kasprintf Date: Wed, 20 Sep 2017 12:43:09 +0530 Message-Id: <1505891589-6632-3-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1505891589-6632-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1505891589-6632-1-git-send-email-arvind.yadav.cs@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 732 Lines: 23 devm_kasprintf() can fail here and we must check its return value. Signed-off-by: Arvind Yadav --- drivers/gpio/gpio-tb10x.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpio/gpio-tb10x.c b/drivers/gpio/gpio-tb10x.c index 091ffaa..ac6f2a9 100644 --- a/drivers/gpio/gpio-tb10x.c +++ b/drivers/gpio/gpio-tb10x.c @@ -193,6 +193,9 @@ static int tb10x_gpio_probe(struct platform_device *pdev) tb10x_gpio->gc.label = devm_kasprintf(&pdev->dev, GFP_KERNEL, "%pOF", pdev->dev.of_node); + if (!tb10x_gpio->gc.label) + return -ENOMEM; + tb10x_gpio->gc.parent = &pdev->dev; tb10x_gpio->gc.owner = THIS_MODULE; tb10x_gpio->gc.direction_input = tb10x_gpio_direction_in; -- 1.9.1