Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751641AbdITHVd (ORCPT ); Wed, 20 Sep 2017 03:21:33 -0400 Received: from mail-wr0-f195.google.com ([209.85.128.195]:38758 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751000AbdITHVb (ORCPT ); Wed, 20 Sep 2017 03:21:31 -0400 X-Google-Smtp-Source: AOwi7QB/WIK28u4cqmrg/7RfhTiBWIphutDEUHSnPk2Ed+sEatOPMfuBqjYFMnbRW7fpeAdA7tJ3XQ== Date: Wed, 20 Sep 2017 09:21:22 +0200 From: Corentin Labbe To: Maxime Ripard Cc: vinod.koul@intel.com, dan.j.williams@intel.com, wens@csie.org, dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dmaengine: sun6i: sun4i-gpadc: use of_device_get_match_data Message-ID: <20170920072122.GA19920@Red> References: <20170919184447.4479-1-clabbe.montjoie@gmail.com> <20170920065814.fle73gxbu3oyqsr4@flea.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170920065814.fle73gxbu3oyqsr4@flea.home> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 601 Lines: 22 On Wed, Sep 20, 2017 at 08:58:14AM +0200, Maxime Ripard wrote: > Hi, > > On Tue, Sep 19, 2017 at 06:44:47PM +0000, Corentin Labbe wrote: > > The usage of of_device_get_match_data reduce the code size a bit. > > Furthermore, it prevents an improbable dereference when > > of_match_device() return NULL. > > > > Signed-off-by: Corentin Labbe > > The prefix of your commit title is wrong, this isn't about the GPADC. > > Once fixed, > Acked-by: Maxime Ripard > > Maxime > A copy/paste error, sorry I will resend thanks Corentin Labbe