Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751904AbdITIaF (ORCPT ); Wed, 20 Sep 2017 04:30:05 -0400 Received: from mail-wm0-f50.google.com ([74.125.82.50]:48979 "EHLO mail-wm0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751679AbdITIaC (ORCPT ); Wed, 20 Sep 2017 04:30:02 -0400 X-Google-Smtp-Source: AOwi7QCJfD315mk/kPfdx/pj0qtKHeHLAbYm8OhMpftd4knQI4hVOg7TkPQM8eNmBBZU78pQ6Q7u+A== Subject: Re: [PATCH 2/2] ARM64: dts: meson-gxm: Add support for Khadas VIM2 To: Martin Blumenstingl Cc: khilman@baylibre.com, carlo@caione.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, Gouwa , linux-arm-kernel@lists.infradead.org References: <1505832820-3517-1-git-send-email-narmstrong@baylibre.com> <1505832820-3517-3-git-send-email-narmstrong@baylibre.com> From: Neil Armstrong Organization: Baylibre Message-ID: <84171990-f5f2-d7d2-2bf6-d28390daac4a@baylibre.com> Date: Wed, 20 Sep 2017 10:29:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1587 Lines: 57 On 09/19/2017 07:55 PM, Martin Blumenstingl wrote: > Hi Neil, > > On Tue, Sep 19, 2017 at 4:53 PM, Neil Armstrong wrote: >> The Khadas VIM2 is a Single Board Computer, respin of the origin >> Khadas VIM board, using an Amlogic S912 SoC and more server oriented. >> >> It provides the same external connectors and header pinout, plus a SPI >> NOR Flash, a reprogrammable STM8S003 MCU, FPC Connector, Cooling FAN header >> and Pogo Pads Arrays. >> >> Cc: Gouwa >> Signed-off-by: Neil Armstrong >> --- >> Documentation/devicetree/bindings/arm/amlogic.txt | 1 + >> arch/arm64/boot/dts/amlogic/Makefile | 1 + >> .../boot/dts/amlogic/meson-gxm-khadas-vim2.dts | 401 +++++++++++++++++++++ >> 3 files changed, 403 insertions(+) >> create mode 100644 arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts >> [...] >> +&external_mdio { >> + external_phy: ethernet-phy@1 { >> + compatible = "ethernet-phy-id001c.c916", "ethernet-phy-ieee802.3-c22"; > could you please remove the compatible property and replace it with a > comment as explained in [0]? > Ok >> + reg = <0>; >> + max-speed = <1000>; >> + }; >> +}; >> + [...] > > with that and Jerome's comments fixed: > Acked-by: Martin Blumenstingl > > > Regards, > Martin > > > [0] http://lists.infradead.org/pipermail/linux-amlogic/2017-September/004729.html > Thanks Martin ! I'll send a v2 when eMMC DTS patches goes in 4.14-rc2. Neil