Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751811AbdITIp6 (ORCPT ); Wed, 20 Sep 2017 04:45:58 -0400 Received: from mail-lf0-f66.google.com ([209.85.215.66]:37354 "EHLO mail-lf0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751602AbdITIpz (ORCPT ); Wed, 20 Sep 2017 04:45:55 -0400 X-Google-Smtp-Source: AOwi7QBOIOJlFXU146He6BUi3nhJTMSe9Efdlz+iXRg+QqH1lqZhV2coXVG3L965twp47YLwUu+ESonvl9mNX7JtnG4= MIME-Version: 1.0 In-Reply-To: <20170824120349.2323-1-ganapatrao.kulkarni@cavium.com> References: <20170824120349.2323-1-ganapatrao.kulkarni@cavium.com> From: Ganapatrao Kulkarni Date: Wed, 20 Sep 2017 14:15:52 +0530 Message-ID: Subject: Re: [PATCH v6 0/4] Add support for ThunderX2 pmu events using json files To: Ganapatrao Kulkarni Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Will Deacon , catalin.marinas@arm.com, mark.rutland@arm.com, Arnaldo Carvalho de Melo , alexander.shishkin@linux.intel.com, peterz@infradead.org, mingo@redhat.com, jnair@caviumnetworks.com, Zhangshaokun , Jonathan.Cameron@huawei.com, Robert.Richter@cavium.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1983 Lines: 59 Hi Will, any further comments? On Thu, Aug 24, 2017 at 5:33 PM, Ganapatrao Kulkarni wrote: > Extending json/jevent framework for parsing arm64 event files. > Adding jevents for ThunderX2 implementation defined PMU events. > > v6 : Addressed comments [1] [2] > > [1] https://patchwork.kernel.org/patch/9903099/ > [2] https://patchwork.kernel.org/patch/9853899/ > > v5: > - Addressed comments from Arnaldo. > - Rebased to 4.13-rc5 > > v4: > - Rebased to 4.13-rc1 > > v3: > - Addressed comments from Will Deacon and Jayachandran C. > - Rebased to 4.12-rc1 > > v2: > - Updated as per Mark Rutland's suggestions. > - Added provision for get_cpuid_str to get cpu id string > from associated cpus of pmu core device. > > v1: Initial patchset. > > Ganapatrao Kulkarni (4): > perf utils: passing pmu as a parameter to function get_cpuid_str > perf tools arm64: Add support for get_cpuid_str function. > perf utils: Add helper function is_pmu_core to detect PMU CORE devices > perf vendor events arm64: Add ThunderX2 implementation defined pmu > core events > > tools/perf/arch/arm64/util/Build | 1 + > tools/perf/arch/arm64/util/header.c | 60 +++++++++++++++++++++ > tools/perf/arch/powerpc/util/header.c | 2 +- > tools/perf/arch/x86/util/header.c | 2 +- > tools/perf/pmu-events/arch/arm64/mapfile.csv | 15 ++++++ > .../arm64/thunderx2/implementation-defined.json | 62 ++++++++++++++++++++++ > tools/perf/util/header.h | 3 +- > tools/perf/util/pmu.c | 48 ++++++++++++++--- > 8 files changed, 182 insertions(+), 11 deletions(-) > create mode 100644 tools/perf/arch/arm64/util/header.c > create mode 100644 tools/perf/pmu-events/arch/arm64/mapfile.csv > create mode 100644 tools/perf/pmu-events/arch/arm64/thunderx2/implementation-defined.json > > -- > 2.9.4 > thanks Ganapat