Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751685AbdITKFG (ORCPT ); Wed, 20 Sep 2017 06:05:06 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:51885 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751468AbdITKFE (ORCPT ); Wed, 20 Sep 2017 06:05:04 -0400 Message-ID: <1505901896.7865.4.camel@pengutronix.de> Subject: Re: [PATCH v2 1/2] [media] coda: Handle return value of kasprintf From: Philipp Zabel To: Arvind Yadav , mchehab@kernel.org, hans.verkuil@cisco.com, sean@mess.org, andi.shyti@samsung.com Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 20 Sep 2017 12:04:56 +0200 In-Reply-To: <5533660490db4a91bb25e3984c3d6bd20eb230f6.1505899966.git.arvind.yadav.cs@gmail.com> References: <5533660490db4a91bb25e3984c3d6bd20eb230f6.1505899966.git.arvind.yadav.cs@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 353 Lines: 14 On Wed, 2017-09-20 at 15:10 +0530, Arvind Yadav wrote: > kasprintf() can fail here and we must check its return value. > > Signed-off-by: Arvind Yadav --- > changes in v2 : > Calling coda_free_framebuffers to release already allocated buffers. Thanks, Reviewed-by: Philipp Zabel regards Philipp