Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751833AbdITKHV (ORCPT ); Wed, 20 Sep 2017 06:07:21 -0400 Received: from mail-pg0-f67.google.com ([74.125.83.67]:36887 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751747AbdITKHS (ORCPT ); Wed, 20 Sep 2017 06:07:18 -0400 X-Google-Smtp-Source: AOwi7QD1KIjnoDrEhvV05ZXt7oBjvjIR5DMdKX9xtr9DRW+SfeFgC5Wyqqd54IoWTKmmSYkL3joxPA== From: Arvind Yadav To: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, timur@tabi.org, nicoleotsuka@gmail.com, Xiubo.Lee@gmail.com, fabio.estevam@nxp.com, peter.ujfalusi@ti.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org, linux-omap@vger.kernel.org Subject: [PATCH 2/3] ASoC: fsl-asoc-card: Handle return value of devm_kasprintf Date: Wed, 20 Sep 2017 15:36:10 +0530 Message-Id: <1505901971-12004-3-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1505901971-12004-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1505901971-12004-1-git-send-email-arvind.yadav.cs@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 686 Lines: 22 devm_kasprintf() can fail here and we must check its return value. Signed-off-by: Arvind Yadav --- sound/soc/fsl/fsl-asoc-card.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/fsl/fsl-asoc-card.c b/sound/soc/fsl/fsl-asoc-card.c index 2db4d0c..86f240b 100644 --- a/sound/soc/fsl/fsl-asoc-card.c +++ b/sound/soc/fsl/fsl-asoc-card.c @@ -639,6 +639,8 @@ static int fsl_asoc_card_probe(struct platform_device *pdev) devm_kasprintf(&pdev->dev, GFP_KERNEL, "ac97-codec.%u", (unsigned int)idx); + if (!priv->dai_link[0].codec_name) + goto asrc_fail; } priv->dai_link[0].platform_of_node = cpu_np; -- 1.9.1