Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751873AbdITL3o (ORCPT ); Wed, 20 Sep 2017 07:29:44 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:33465 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751554AbdITL3m (ORCPT ); Wed, 20 Sep 2017 07:29:42 -0400 Date: Wed, 20 Sep 2017 13:29:40 +0200 From: Pavel Machek To: Jacek Anaszewski Cc: Dmitry Torokhov , "linux-input@vger.kernel.org" , David Lin , Jonathan Corbet , Richard Purdie , Hans de Goede , Greg Kroah-Hartman , Rob Herring , Rom Lemarchand , "linux-doc@vger.kernel.org" , lkml , "linux-leds@vger.kernel.org" Subject: Re: Vibrations in input vs. LED was Re: [PATCH v2 0/3] led: ledtrig-transient: add support for hrtimer Message-ID: <20170920112940.GB4283@amd> References: <9c75c3a9-4123-c7f3-7725-45ba752d672a@gmail.com> <20170914205804.GA24339@amd> <7a611993-ebaa-08bb-b10c-ebe4fb9ca33a@gmail.com> <0076adca-f843-f99f-09ce-b9839b3e7706@gmail.com> <20170917182251.GA15328@amd> <9d5d045e-5019-e132-9449-7fb40b1b7895@gmail.com> <4226b524-35e1-16c0-f6ca-e339dd2eab1d@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="qlTNgmc+xy1dBmNv" Content-Disposition: inline In-Reply-To: <4226b524-35e1-16c0-f6ca-e339dd2eab1d@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1832 Lines: 50 --qlTNgmc+xy1dBmNv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > >>> I'd leave the decision to the user. We could add a note to the > >>> Documentation/leds/ledtrig-transient.txt that force feedback interface > >>> should be preferable choice for driving vibrate devices. > >>> However only if following conditions are met: > >> > >> What I meant is that it is my decision, as a LED subsystem maintainer, > >> to accept the addition of a note about some other subsystem offering > >> an equivalent or even better substitute of the feature being available > >> in the subsystem I am responsible for. And I will accept such a patch > >> only if mentioned conditions are met. > >=20 > > Having the wording in documentation does not in any way stops Android > > folks from continuing [ab]using the transient trigger. But this is > > their choice. The purpose of documentation is to document the best > > practices, not all possible crazy solutions one can come up with. >=20 > Yes. but if the information has been in place for years, we can't > just remove it without giving an instruction on how to use the > substitute. I gave you information how to use the substitute. I already suggested patch to documentation. If you do the same, maybe we can agree on documentation update. Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --qlTNgmc+xy1dBmNv Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlnCUSQACgkQMOfwapXb+vLysACgofyBm06BNJXInztADrzfJao/ hzgAnA3hZk7mdoPSX+RqchLgSiGdVZZW =jomO -----END PGP SIGNATURE----- --qlTNgmc+xy1dBmNv--