Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S269133AbTGJJ31 (ORCPT ); Thu, 10 Jul 2003 05:29:27 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S269134AbTGJJ31 (ORCPT ); Thu, 10 Jul 2003 05:29:27 -0400 Received: from rumms.uni-mannheim.de ([134.155.50.52]:53222 "EHLO rumms.uni-mannheim.de") by vger.kernel.org with ESMTP id S269133AbTGJJ3Y (ORCPT ); Thu, 10 Jul 2003 05:29:24 -0400 From: Thomas Schlichter To: William Lee Irwin III Subject: Re: 2.5.74-mm3 - apm_save_cpus() Macro still bombs out Date: Thu, 10 Jul 2003 11:42:35 +0200 User-Agent: KMail/1.5.9 Cc: Piet Delaney , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20030708223548.791247f5.akpm@osdl.org> <200307101122.59138.schlicht@uni-mannheim.de> <20030710092720.GT15452@holomorphy.com> In-Reply-To: <20030710092720.GT15452@holomorphy.com> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200307101142.37137.schlicht@uni-mannheim.de> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 960 Lines: 23 On Thursday 10 July 2003 11:27, William Lee Irwin III wrote: > On Thu, Jul 10, 2003 at 11:22:56AM +0200, Thomas Schlichter wrote: > > Well, I didn't try the CPU_MASK_NONE fix. I am using my fix attached to > > my first mail, but Andrew ment it was too complex (your quoting from > > above). So he proposed the simpler fix, wich simply looked good to me... > > Could you try the following? OK, I tried it. For me it compiles! But the size of the resulting objectfile's text section is about 64bytes larger than with my patch. So it seems that gcc3.3 wasn't able to optimize away all the unneeded stuff... And I don't think my patch is that ugly, but hey, it's your decision... Best regards Thomas Schlichter - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/