Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751750AbdITOXO (ORCPT ); Wed, 20 Sep 2017 10:23:14 -0400 Received: from mail.savoirfairelinux.com ([208.88.110.44]:47328 "EHLO mail.savoirfairelinux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751529AbdITOXN (ORCPT ); Wed, 20 Sep 2017 10:23:13 -0400 From: Vivien Didelot To: Florian Fainelli , netdev@vger.kernel.org Cc: Florian Fainelli , Andrew Lunn , "David S. Miller" , open list Subject: Re: [PATCH net-next] net: dsa: Utilize dsa_slave_dev_check() In-Reply-To: <20170920010038.12393-1-f.fainelli@gmail.com> References: <20170920010038.12393-1-f.fainelli@gmail.com> Date: Wed, 20 Sep 2017 10:19:39 -0400 Message-ID: <871sn178qs.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 429 Lines: 15 Hi Florian, Florian Fainelli writes: > Instead of open coding the check. > > Signed-off-by: Florian Fainelli If we do need to use it outside one day, we may think about renaming netdev_uses_dsa() to netdev_is_dsa_master() and renaming dsa_slave_dev_check() to netdev_is_dsa_slave(). In the meantime, looks good! Reviewed-by: Vivien Didelot