Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751852AbdITOfm (ORCPT ); Wed, 20 Sep 2017 10:35:42 -0400 Received: from mx2.suse.de ([195.135.220.15]:52268 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751824AbdITOfk (ORCPT ); Wed, 20 Sep 2017 10:35:40 -0400 Date: Wed, 20 Sep 2017 16:35:39 +0200 From: Jan Kara To: Jens Axboe Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, hannes@cmpxchg.org, clm@fb.com, jack@suse.cz Subject: Re: [PATCH 4/6] fs-writeback: make wb_start_writeback() static Message-ID: <20170920143539.GE11106@quack2.suse.cz> References: <1505850787-18311-1-git-send-email-axboe@kernel.dk> <1505850787-18311-5-git-send-email-axboe@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1505850787-18311-5-git-send-email-axboe@kernel.dk> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1626 Lines: 51 On Tue 19-09-17 13:53:05, Jens Axboe wrote: > We don't have any callers outside of fs-writeback.c anymore, > make it private. > > Signed-off-by: Jens Axboe You can add: Reviewed-by: Jan Kara Honza > --- > fs/fs-writeback.c | 4 ++-- > include/linux/backing-dev.h | 2 -- > 2 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c > index 03fda0830bf8..7564347914f8 100644 > --- a/fs/fs-writeback.c > +++ b/fs/fs-writeback.c > @@ -933,8 +933,8 @@ static void bdi_split_work_to_wbs(struct backing_dev_info *bdi, > > #endif /* CONFIG_CGROUP_WRITEBACK */ > > -void wb_start_writeback(struct bdi_writeback *wb, long nr_pages, > - bool range_cyclic, enum wb_reason reason) > +static void wb_start_writeback(struct bdi_writeback *wb, long nr_pages, > + bool range_cyclic, enum wb_reason reason) > { > struct wb_writeback_work *work; > > diff --git a/include/linux/backing-dev.h b/include/linux/backing-dev.h > index 854e1bdd0b2a..157e950a70dc 100644 > --- a/include/linux/backing-dev.h > +++ b/include/linux/backing-dev.h > @@ -38,8 +38,6 @@ static inline struct backing_dev_info *bdi_alloc(gfp_t gfp_mask) > return bdi_alloc_node(gfp_mask, NUMA_NO_NODE); > } > > -void wb_start_writeback(struct bdi_writeback *wb, long nr_pages, > - bool range_cyclic, enum wb_reason reason); > void wb_start_background_writeback(struct bdi_writeback *wb); > void wb_workfn(struct work_struct *work); > void wb_wakeup_delayed(struct bdi_writeback *wb); > -- > 2.7.4 > -- Jan Kara SUSE Labs, CR