Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751840AbdITO4O (ORCPT ); Wed, 20 Sep 2017 10:56:14 -0400 Received: from frisell.zx2c4.com ([192.95.5.64]:38921 "EHLO frisell.zx2c4.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751646AbdITO4K (ORCPT ); Wed, 20 Sep 2017 10:56:10 -0400 X-Google-Smtp-Source: AOwi7QAQf/C9lUipai7NA2D5euEdNwqLdWcvShth1Pptu+EfAvrWmdCrsFTakzMsQcXknAkqHs1CiIDIacQStspUmtQ= MIME-Version: 1.0 In-Reply-To: <27444.1505835505@warthog.procyon.org.uk> References: <20170917115217.15805-1-Jason@zx2c4.com> <27444.1505835505@warthog.procyon.org.uk> From: "Jason A. Donenfeld" Date: Wed, 20 Sep 2017 16:56:06 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v6] security/keys: rewrite all of big_key crypto To: David Howells Cc: linux-security-module@vger.kernel.org, keyrings@vger.kernel.org, kernel-hardening@lists.openwall.com, LKML , Eric Biggers , Herbert Xu , Kirill Marinushkin , security@kernel.org, stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 555 Lines: 13 On Tue, Sep 19, 2017 at 5:38 PM, David Howells wrote: > Jason A. Donenfeld wrote: > >> And, some error paths forgot to zero out sensitive >> material, so this patch changes a kfree into a kzfree. > > Can you split that out into a separate preparatory patch? > > Also, I recommend limiting the lines in your patch description to 75 chars > lest you get people who run checkpatch on everything pestering you ;-) No problem. Will split that out, then fix the description, and resubmit as v7. Coming your way shortly.