Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751782AbdITPEF (ORCPT ); Wed, 20 Sep 2017 11:04:05 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:34723 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751581AbdITPEE (ORCPT ); Wed, 20 Sep 2017 11:04:04 -0400 Date: Wed, 20 Sep 2017 08:04:00 -0700 From: Christoph Hellwig To: Meng Xu Cc: sathya.prakash@broadcom.com, chaitra.basappa@broadcom.com, suganath-prabu.subramani@broadcom.com, jejb@linux.vnet.ibm.com, martin.petersen@oracle.com, MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, meng.xu@gatech.edu, sanidhya@gatech.edu, taesoo@gatech.edu Subject: Re: [PATCH] mpt3sas: downgrade full copy_from_user to access_ok check Message-ID: <20170920150400.GA18201@infradead.org> References: <1505877071-76996-1-git-send-email-mengxu.gatech@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1505877071-76996-1-git-send-email-mengxu.gatech@gmail.com> User-Agent: Mutt/1.8.3 (2017-05-23) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 223 Lines: 5 On Tue, Sep 19, 2017 at 11:11:11PM -0400, Meng Xu wrote: > Since right after the user copy, we are going to > memset(&karg, 0, sizeof(karg)), I guess an access_ok check is enough? The right thing is to remove it entirely.