Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751833AbdITQUA (ORCPT ); Wed, 20 Sep 2017 12:20:00 -0400 Received: from mga06.intel.com ([134.134.136.31]:13022 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751550AbdITQT7 (ORCPT ); Wed, 20 Sep 2017 12:19:59 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,421,1500966000"; d="scan'208";a="1016649195" Subject: Re: [PATCH v5 03/10] swiotlb: Map the buffer if it was unmapped by XPFO To: Tycho Andersen , linux-kernel@vger.kernel.org References: <20170809200755.11234-1-tycho@docker.com> <20170809200755.11234-4-tycho@docker.com> Cc: linux-mm@kvack.org, kernel-hardening@lists.openwall.com, Marco Benatto , Juerg Haefliger , Juerg Haefliger From: Dave Hansen Message-ID: <5877eed8-0e8e-0dec-fdc7-de01bdbdafa8@intel.com> Date: Wed, 20 Sep 2017 09:19:56 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170809200755.11234-4-tycho@docker.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1016 Lines: 28 On 08/09/2017 01:07 PM, Tycho Andersen wrote: > --- a/lib/swiotlb.c > +++ b/lib/swiotlb.c > @@ -420,8 +420,9 @@ static void swiotlb_bounce(phys_addr_t orig_addr, phys_addr_t tlb_addr, > { > unsigned long pfn = PFN_DOWN(orig_addr); > unsigned char *vaddr = phys_to_virt(tlb_addr); > + struct page *page = pfn_to_page(pfn); > > - if (PageHighMem(pfn_to_page(pfn))) { > + if (PageHighMem(page) || xpfo_page_is_unmapped(page)) { > /* The buffer does not have a mapping. Map it in and copy */ > unsigned int offset = orig_addr & ~PAGE_MASK; > char *buffer; This is a little scary. I wonder how many more of these are in the kernel, like: > static inline void *skcipher_map(struct scatter_walk *walk) > { > struct page *page = scatterwalk_page(walk); > > return (PageHighMem(page) ? kmap_atomic(page) : page_address(page)) + > offset_in_page(walk->offset); > } Is there any better way to catch these? Like, can we add some debugging to check for XPFO pages in __va()?