Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752051AbdITQbf (ORCPT <rfc822;w@1wt.eu>);
        Wed, 20 Sep 2017 12:31:35 -0400
Received: from mail-it0-f54.google.com ([209.85.214.54]:51436 "EHLO
        mail-it0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751378AbdITQbd (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 20 Sep 2017 12:31:33 -0400
X-Google-Smtp-Source: AOwi7QBQfgWjsI7l/I2y15abiCEiIXHZXDMkLfPT8/p+aCZ2Kk11fpHYHn19D2dN9TldDxsL0NKXP5X4FFE7t0zIGR4=
MIME-Version: 1.0
In-Reply-To: <CANwerB1Pn2YAN9VmbSAzD3Se47ThAQNBRLH71HV_e7VZ34yAPQ@mail.gmail.com>
References: <20170919115042.6800-1-net147@gmail.com> <CAJcbSZEiHW=yH+ATvLq=am4nbVdhbqAxkH-+jEymhNkN+Pkb=A@mail.gmail.com>
 <CANwerB1Pn2YAN9VmbSAzD3Se47ThAQNBRLH71HV_e7VZ34yAPQ@mail.gmail.com>
From: Thomas Garnier <thgarnie@google.com>
Date: Wed, 20 Sep 2017 09:31:31 -0700
Message-ID: <CAJcbSZF1PuMPTM3uZOVzfaUXj1Q3+6Nj2c6DXU+RDrwT8P13Tw@mail.gmail.com>
Subject: Re: [PATCH] ARM: uaccess: Add missing include for set_thread_flag
To: Jonathan Liu <net147@gmail.com>
Cc: Russell King <linux@armlinux.org.uk>,
        Thomas Gleixner <tglx@linutronix.de>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2004
Lines: 71

On Tue, Sep 19, 2017 at 2:35 PM, Jonathan Liu <net147@gmail.com> wrote:
>
> Hi Thomas,
>
> The top of the C source file I am compiling has:
> #include <linux/kernel.h>
> #include <asm/uaccess.h>
>
> Tracing through the asm/uaccess.h include I see
> asm/uaccess.h -> asm/domain.h -> asm/thread_info.h
>
> but set_thread_info is defined in linux/thread_info.h not
> asm/thread_info.h (see
> http://elixir.free-electrons.com/linux/v4.14-rc1/ident/set_thread_flag).

I see, I think I could not reproduce this issue because I already
reverted the original commit in favor of a different approach on
linux-next (see commit 2404269bc4e77a67875c8db6667be34c9913c96e).

Let me know if this commit resolve the issue and thanks for reaching out.

>
> Regards,
> Jonathan
>
> On 20 September 2017 at 00:32, Thomas Garnier <thgarnie@google.com> wrote:
> > On Tue, Sep 19, 2017 at 4:50 AM, Jonathan Liu <net147@gmail.com> wrote:
> >> Fixes "implicit declaration of function" compile error for out-of-tree
> >> kernel modules including asm/uaccess.h.
> >
> > I failed to reproduce this issue by creating an out of tree module
> > with a separate file (with only uaccess.h). Are you using a special
> > config?
> >
> > Looking at the headers on uaccess.h. You get thread_info through:
> >
> >  asm/domain.h -> asm/thread_info.h
> >
> >>
> >> Fixes: 73ac5d6a2b6a ("arm/syscalls: Check address limit on user-mode return")
> >> Signed-off-by: Jonathan Liu <net147@gmail.com>
> >> ---
> >>  arch/arm/include/asm/uaccess.h | 1 +
> >>  1 file changed, 1 insertion(+)
> >>
> >> diff --git a/arch/arm/include/asm/uaccess.h b/arch/arm/include/asm/uaccess.h
> >> index 87936dd5d151..13d1877ffb75 100644
> >> --- a/arch/arm/include/asm/uaccess.h
> >> +++ b/arch/arm/include/asm/uaccess.h
> >> @@ -17,6 +17,7 @@
> >>  #include <asm/unified.h>
> >>  #include <asm/compiler.h>
> >>
> >> +#include <linux/thread_info.h>
> >>  #include <asm/extable.h>
> >>
> >>  /*
> >> --
> >> 2.13.2
> >>
> >
> >
> >
> > --
> > Thomas




-- 
Thomas