Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751471AbdITR55 (ORCPT ); Wed, 20 Sep 2017 13:57:57 -0400 Received: from terminus.zytor.com ([65.50.211.136]:48575 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750938AbdITR54 (ORCPT ); Wed, 20 Sep 2017 13:57:56 -0400 Subject: Re: [PATCH 2/2] x86/asm: Fix inline asm call constraints for clang To: Dmitry Vyukov Cc: Josh Poimboeuf , "x86@kernel.org" , LKML , Ingo Molnar , Thomas Gleixner , Andy Lutomirski , Linus Torvalds , Alexander Potapenko , Matthias Kaehlcke , Arnd Bergmann , Peter Zijlstra , Andrey Ryabinin References: <31e96e6bcfcb47725e15a093b9c31660dfaad430.1505846562.git.jpoimboe@redhat.com> From: "H. Peter Anvin" Message-ID: <7e39ef18-3e60-8cc9-ec4f-1cd02ade171f@zytor.com> Date: Wed, 20 Sep 2017 10:46:24 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 438 Lines: 12 On 09/20/17 10:38, Dmitry Vyukov wrote: > > I think we need just the frame itself and RSP pointing below this > frame. If we don't have a frame, CALL instruction will smash whatever > RSP happens to point to. Compiler doesn't have to setup RSP to point > below used part of stack in leaf functions. > In the kernel it does. Redzoning is not allowed in the kernel, because interrupts or exceptions would also smash the redzone. -hpa