Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751799AbdITShf (ORCPT ); Wed, 20 Sep 2017 14:37:35 -0400 Received: from mail-pg0-f65.google.com ([74.125.83.65]:38345 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751626AbdITShd (ORCPT ); Wed, 20 Sep 2017 14:37:33 -0400 X-Google-Smtp-Source: AOwi7QBd+UU+Hnu69iwU2SnGJUTRXW9vGlZPGiLo0Ymqt/AGj30DumObz4dvlIvFZJU4tSOuV4DVng== Date: Wed, 20 Sep 2017 20:37:28 +0200 From: Daniel Vetter To: Chris Wilson Cc: Colin King , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , David Airlie , dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/i915: remove redundant variable hw_check Message-ID: <20170920183728.GE25248@dvetter-linux.ger.corp.intel.com> Mail-Followup-To: Chris Wilson , Colin King , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , David Airlie , dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20170914162154.11304-1-colin.king@canonical.com> <150541731769.19729.8961451433626686725@mail.alporthouse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <150541731769.19729.8961451433626686725@mail.alporthouse.com> X-Operating-System: Linux dvetter-linux.ger.corp.intel.com 4.12.9-200.fc25.x86_64 User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2258 Lines: 58 On Thu, Sep 14, 2017 at 08:28:37PM +0100, Chris Wilson wrote: > Quoting Colin King (2017-09-14 17:21:54) > > From: Colin Ian King > > > > hw_check is being assigned and updated but is no longer being read, > > hence it is redundant and can be removed. > > > > Detected by clang scan-build: > > "warning: Value stored to 'hw_check' during its initialization > > is never read" > > > > Fixes: f6d1973db2d2 ("drm/i915: Move modeset state verifier calls") > > Signed-off-by: Colin Ian King > Reviewed-by: Chris Wilson Applied, thanks for patch&review. -Daniel > > --- > > drivers/gpu/drm/i915/intel_display.c | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c > > index f17275519484..ac261eaa5ba5 100644 > > --- a/drivers/gpu/drm/i915/intel_display.c > > +++ b/drivers/gpu/drm/i915/intel_display.c > > @@ -12359,7 +12359,6 @@ static void intel_atomic_commit_tail(struct drm_atomic_state *state) > > struct drm_crtc_state *old_crtc_state, *new_crtc_state; > > struct drm_crtc *crtc; > > struct intel_crtc_state *intel_cstate; > > - bool hw_check = intel_state->modeset; > > u64 put_domains[I915_MAX_PIPES] = {}; > > unsigned crtc_vblank_mask = 0; > > int i; > > @@ -12376,7 +12375,6 @@ static void intel_atomic_commit_tail(struct drm_atomic_state *state) > > > > if (needs_modeset(new_crtc_state) || > > to_intel_crtc_state(new_crtc_state)->update_pipe) { > > - hw_check = true; > > > > put_domains[to_intel_crtc(crtc)->pipe] = > > modeset_get_crtc_power_domains(crtc, > > -- > > 2.14.1 > > > > _______________________________________________ > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch