Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751669AbdITUJk (ORCPT ); Wed, 20 Sep 2017 16:09:40 -0400 Received: from mail-wm0-f51.google.com ([74.125.82.51]:43936 "EHLO mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750872AbdITUJh (ORCPT ); Wed, 20 Sep 2017 16:09:37 -0400 X-Google-Smtp-Source: AOwi7QBykk/6Y94TIWxCwDJ533sZkSBfgmBGrRturmNovP18Dn8lBJG1ppmLZmTP4jXeQBbkJ8eEbw== Subject: Re: Vibrations in input vs. LED was Re: [PATCH v2 0/3] led: ledtrig-transient: add support for hrtimer To: Pavel Machek References: <9c75c3a9-4123-c7f3-7725-45ba752d672a@gmail.com> <20170914205804.GA24339@amd> <7a611993-ebaa-08bb-b10c-ebe4fb9ca33a@gmail.com> <0076adca-f843-f99f-09ce-b9839b3e7706@gmail.com> <20170917182251.GA15328@amd> <9d5d045e-5019-e132-9449-7fb40b1b7895@gmail.com> <4226b524-35e1-16c0-f6ca-e339dd2eab1d@gmail.com> <20170920112940.GB4283@amd> Cc: Dmitry Torokhov , "linux-input@vger.kernel.org" , David Lin , Jonathan Corbet , Richard Purdie , Hans de Goede , Greg Kroah-Hartman , Rob Herring , Rom Lemarchand , "linux-doc@vger.kernel.org" , lkml , "linux-leds@vger.kernel.org" From: Jacek Anaszewski X-Enigmail-Draft-Status: N1010 Message-ID: <78217fe0-b61d-249c-bf30-787642317255@gmail.com> Date: Wed, 20 Sep 2017 22:08:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170920112940.GB4283@amd> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1670 Lines: 40 On 09/20/2017 01:29 PM, Pavel Machek wrote: >>>>> I'd leave the decision to the user. We could add a note to the >>>>> Documentation/leds/ledtrig-transient.txt that force feedback interface >>>>> should be preferable choice for driving vibrate devices. >>>>> However only if following conditions are met: >>>> >>>> What I meant is that it is my decision, as a LED subsystem maintainer, >>>> to accept the addition of a note about some other subsystem offering >>>> an equivalent or even better substitute of the feature being available >>>> in the subsystem I am responsible for. And I will accept such a patch >>>> only if mentioned conditions are met. >>> >>> Having the wording in documentation does not in any way stops Android >>> folks from continuing [ab]using the transient trigger. But this is >>> their choice. The purpose of documentation is to document the best >>> practices, not all possible crazy solutions one can come up with. >> >> Yes. but if the information has been in place for years, we can't >> just remove it without giving an instruction on how to use the >> substitute. > > I gave you information how to use the substitute. That information was quite vague. I'd like to see a sample application in tools/input. > I already suggested patch to documentation. If you do the same, maybe > we can agree on documentation update. Your patch was just removing few lines of documentation. I'd expect more empathic approach to the current users, i.e.: - pointer to the sample application in tools/input showing how to setup gpio driven vibrate device with use of ff interface with 1kHz vibration frequency. -- Best regards, Jacek Anaszewski