Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752299AbdITUyy (ORCPT ); Wed, 20 Sep 2017 16:54:54 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:35202 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752169AbdITUxC (ORCPT ); Wed, 20 Sep 2017 16:53:02 -0400 X-Google-Smtp-Source: AOwi7QACKgS9DbFFoKBKNKeQh4mL3n3ircURj796PaW2+j2RaUIzUMvYICfVYDIVfDGhd36MHFFQzA== Date: Wed, 20 Sep 2017 15:53:00 -0500 From: Rob Herring To: Stefan =?iso-8859-1?Q?Br=FCns?= Cc: linux-sunxi@googlegroups.com, devicetree@vger.kernel.org, dmaengine@vger.kernel.org, Vinod Koul , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Maxime Ripard , Chen-Yu Tsai , Code Kipper , Andre Przywara Subject: Re: [PATCH v2 06/10] arm64: allwinner: a64: Add devicetree binding for DMA controller Message-ID: <20170920205300.io3ghr54kzk763kt@rob-hp-laptop> References: <20170917031956.28010-1-stefan.bruens@rwth-aachen.de> <20170917031956.28010-7-stefan.bruens@rwth-aachen.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170917031956.28010-7-stefan.bruens@rwth-aachen.de> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2146 Lines: 62 On Sun, Sep 17, 2017 at 05:19:52AM +0200, Stefan Br?ns wrote: > The A64 is register compatible with the H3, but has a different number > of dma channels and request ports. > > Attach additional properties to the node to allow future reuse of the > compatible for controllers with different number of channels/requests. > > If dma-requests is not specified, the register layout defined maximum > of 32 is used. > > Signed-off-by: Stefan Br?ns > --- > .../devicetree/bindings/dma/sun6i-dma.txt | 26 ++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/Documentation/devicetree/bindings/dma/sun6i-dma.txt b/Documentation/devicetree/bindings/dma/sun6i-dma.txt > index 98fbe1a5c6dd..6ebc79f95202 100644 > --- a/Documentation/devicetree/bindings/dma/sun6i-dma.txt > +++ b/Documentation/devicetree/bindings/dma/sun6i-dma.txt > @@ -27,6 +27,32 @@ Example: > #dma-cells = <1>; > }; > > +------------------------------------------------------------------------------ > +For A64 DMA controller: > + > +Required properties: > +- compatible: "allwinner,sun50i-a64-dma" > +- dma-channels: Number of DMA channels supported by the controller. > + Refer to Documentation/devicetree/bindings/dma/dma.txt > +- all properties above, i.e. reg, interrupts, clocks, resets and #dma-cells > + > +Optional properties: > +- dma-requests: Number of DMA request signals supported by the controller. > + Refer to Documentation/devicetree/bindings/dma/dma.txt > + > +Example: > + dma: dma-controller@01c02000 { Drop the leading 0. Building dtbs with W=2 will tell you this. With that, Acked-by: Rob Herring > + compatible = "allwinner,sun50i-a64-dma"; > + reg = <0x01c02000 0x1000>; > + interrupts = ; > + clocks = <&ccu CLK_BUS_DMA>; > + dma-channels = <8>; > + dma-requests = <27>; > + resets = <&ccu RST_BUS_DMA>; > + #dma-cells = <1>; > + }; > +------------------------------------------------------------------------------ > + > Clients: > > DMA clients connected to the A31 DMA controller must use the format > -- > 2.14.1 >