Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751813AbdITVW3 (ORCPT ); Wed, 20 Sep 2017 17:22:29 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:38308 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751365AbdITVW2 (ORCPT ); Wed, 20 Sep 2017 17:22:28 -0400 Date: Wed, 20 Sep 2017 14:22:27 -0700 (PDT) Message-Id: <20170920.142227.65942571438912956.davem@davemloft.net> To: yanhaishuang@cmss.chinamobile.com Cc: kuznet@ms2.inr.ac.ru, edumazet@google.com, weiwan@google.com, lucab@debian.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [Patch v3 1/3] ipv4: Namespaceify tcp_fastopen knob From: David Miller In-Reply-To: <1505813896-12121-1-git-send-email-yanhaishuang@cmss.chinamobile.com> References: <1505813896-12121-1-git-send-email-yanhaishuang@cmss.chinamobile.com> X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 20 Sep 2017 14:22:28 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 848 Lines: 21 From: Haishuang Yan Date: Tue, 19 Sep 2017 17:38:14 +0800 > - if ((sysctl_tcp_fastopen & TFO_SERVER_WO_SOCKOPT1) && > - (sysctl_tcp_fastopen & TFO_SERVER_ENABLE) && > + tcp_fastopen = sock_net(sk)->ipv4.sysctl_tcp_fastopen; ^^ Please change that to one space. And also please provide an appropriate "[PATCH vX 0/3] " header posting when you respin this series. > @@ -282,18 +280,19 @@ struct sock *tcp_try_fastopen(struct sock *sk, struct sk_buff *skb, > struct tcp_fastopen_cookie valid_foc = { .len = -1 }; > bool syn_data = TCP_SKB_CB(skb)->end_seq != TCP_SKB_CB(skb)->seq + 1; > struct sock *child; > + int tcp_fastopen = sock_net(sk)->ipv4.sysctl_tcp_fastopen; Please order local variables from longest to shortest line (aka. reverse christmas tree format).