Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751962AbdITVZM (ORCPT ); Wed, 20 Sep 2017 17:25:12 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:38370 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751387AbdITVZJ (ORCPT ); Wed, 20 Sep 2017 17:25:09 -0400 Date: Wed, 20 Sep 2017 14:25:08 -0700 (PDT) Message-Id: <20170920.142508.2226871042948634454.davem@davemloft.net> To: yanhaishuang@cmss.chinamobile.com Cc: kuznet@ms2.inr.ac.ru, edumazet@google.com, weiwan@google.com, lucab@debian.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [Patch v3 2/3] ipv4: Namespaceify tcp_fastopen_key knob From: David Miller In-Reply-To: <1505813896-12121-2-git-send-email-yanhaishuang@cmss.chinamobile.com> References: <1505813896-12121-1-git-send-email-yanhaishuang@cmss.chinamobile.com> <1505813896-12121-2-git-send-email-yanhaishuang@cmss.chinamobile.com> X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 20 Sep 2017 14:25:09 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 501 Lines: 15 From: Haishuang Yan Date: Tue, 19 Sep 2017 17:38:15 +0800 > @@ -128,6 +130,8 @@ struct netns_ipv4 { > struct inet_timewait_death_row tcp_death_row; > int sysctl_max_syn_backlog; > int sysctl_tcp_fastopen; > + struct tcp_fastopen_context __rcu *tcp_fastopen_ctx; > + spinlock_t tcp_fastopen_ctx_lock; > > #ifdef CONFIG_NET_L3_MASTER_DEV > int sysctl_udp_l3mdev_accept; Where are you releasing this context during netns teardown? I think this is a leak.