Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751704AbdITWCe (ORCPT ); Wed, 20 Sep 2017 18:02:34 -0400 Received: from mail-io0-f171.google.com ([209.85.223.171]:51280 "EHLO mail-io0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751499AbdITWCc (ORCPT ); Wed, 20 Sep 2017 18:02:32 -0400 X-Google-Smtp-Source: AOwi7QCc5WBUThkPzapx96z6ajf9a6SH5IrEvTBj3tRWSOGG28C372D5vn/YM8H+BmOt6nhcp/X1zw5RFzz11eh0eoM= MIME-Version: 1.0 In-Reply-To: References: <20170907233246.GA115838@beast> <20170908031906.izqthq6q7qzbry3p@ubuntu-hedt> From: Kees Cook Date: Wed, 20 Sep 2017 15:02:27 -0700 X-Google-Sender-Auth: tVgyrLEMvPyM2i32raNbOwf7EEI Message-ID: Subject: Re: [PATCH] selftests/seccomp: Support glibc 2.26 siginfo_t.h To: Seth Forshee , Shuah Khan Cc: Andy Lutomirski , Will Drewry , "open list:KERNEL SELFTEST FRAMEWORK" , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1379 Lines: 38 On Thu, Sep 7, 2017 at 8:36 PM, Kees Cook wrote: > On Thu, Sep 7, 2017 at 8:19 PM, Seth Forshee wrote: >> On Thu, Sep 07, 2017 at 04:32:46PM -0700, Kees Cook wrote: >>> The 2.26 release of glibc changed how siginfo_t is defined, and the earlier >>> work-around to using the kernel definition are no longer needed. The old >>> way needs to stay around for a while, though. >>> >>> Reported-by: Seth Forshee >>> Cc: Andy Lutomirski >>> Cc: Will Drewry >>> Cc: Shuah Khan >>> Cc: linux-kselftest@vger.kernel.org >>> Cc: stable@vger.kernel.org >>> Signed-off-by: Kees Cook >>> --- >>> Seth, can you double check this to confirm it works for you too? This builds >>> and tests correctly for me on both Ubuntu 17.10 (-proposed) with glibc 2.26 >>> and with earlier distros with 2.24, etc. >> >> It builds and tests correctly for me too, with both glibc 2.26 and 2.24. >> >> Tested-by: Seth Forshee > > Awesome, thanks! > > Shuah, is it possible to land this for v4.14? If it has to wait, > that's probably okay, as I've marked it for -stable, so it'll get > where it needs to be eventually. :) Friendly ping, Shuah, are you able to take this? Thanks! -Kees -- Kees Cook Pixel Security