Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751878AbdITWmk (ORCPT ); Wed, 20 Sep 2017 18:42:40 -0400 Received: from mailout.easymail.ca ([64.68.200.34]:36897 "EHLO mailout.easymail.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751652AbdITWmi (ORCPT ); Wed, 20 Sep 2017 18:42:38 -0400 Reply-To: shuah@kernel.org Subject: Re: [PATCH] selftests/seccomp: Support glibc 2.26 siginfo_t.h To: Kees Cook , Seth Forshee Cc: Andy Lutomirski , Will Drewry , "open list:KERNEL SELFTEST FRAMEWORK" , LKML , Shuah Khan , Shuah Khan References: <20170907233246.GA115838@beast> <20170908031906.izqthq6q7qzbry3p@ubuntu-hedt> From: Shuah Khan Message-ID: <8db4b452-08d1-fb48-2539-e7a2a573fadb@kernel.org> Date: Wed, 20 Sep 2017 16:42:25 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1503 Lines: 40 On 09/20/2017 04:02 PM, Kees Cook wrote: > On Thu, Sep 7, 2017 at 8:36 PM, Kees Cook wrote: >> On Thu, Sep 7, 2017 at 8:19 PM, Seth Forshee wrote: >>> On Thu, Sep 07, 2017 at 04:32:46PM -0700, Kees Cook wrote: >>>> The 2.26 release of glibc changed how siginfo_t is defined, and the earlier >>>> work-around to using the kernel definition are no longer needed. The old >>>> way needs to stay around for a while, though. >>>> >>>> Reported-by: Seth Forshee >>>> Cc: Andy Lutomirski >>>> Cc: Will Drewry >>>> Cc: Shuah Khan >>>> Cc: linux-kselftest@vger.kernel.org >>>> Cc: stable@vger.kernel.org >>>> Signed-off-by: Kees Cook >>>> --- >>>> Seth, can you double check this to confirm it works for you too? This builds >>>> and tests correctly for me on both Ubuntu 17.10 (-proposed) with glibc 2.26 >>>> and with earlier distros with 2.24, etc. >>> >>> It builds and tests correctly for me too, with both glibc 2.26 and 2.24. >>> >>> Tested-by: Seth Forshee >> >> Awesome, thanks! >> >> Shuah, is it possible to land this for v4.14? If it has to wait, >> that's probably okay, as I've marked it for -stable, so it'll get >> where it needs to be eventually. :) > > Friendly ping, Shuah, are you able to take this? > > Thanks! > > -Kees > Yes I can this into 4.14-rc2 or rc3. Thanks for the ping. -- Shuah