Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752131AbdIUA1W (ORCPT ); Wed, 20 Sep 2017 20:27:22 -0400 Received: from mail-io0-f196.google.com ([209.85.223.196]:38255 "EHLO mail-io0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751762AbdIUA1U (ORCPT ); Wed, 20 Sep 2017 20:27:20 -0400 X-Google-Smtp-Source: AOwi7QD82H8C/CjhaXjJxI89XEJGk2c+Gzib9L89ZFeoCXM5ezGC9grS3kxeF5cYe2g/MIHKWRhieVvNShTL5HFV844= MIME-Version: 1.0 In-Reply-To: <20170920223152.100641-2-rajatja@google.com> References: <20170920223152.100641-1-rajatja@google.com> <20170920223152.100641-2-rajatja@google.com> From: "Rafael J. Wysocki" Date: Thu, 21 Sep 2017 02:27:19 +0200 X-Google-Sender-Auth: _wkzfoTu4BsP7O3y-7Btvpbl8dE Message-ID: Subject: Re: [PATCH 2/2] mfd: intel-lpss: switch to suspend_late()/resume_early() To: Rajat Jain Cc: Jarkko Nikula , Andy Shevchenko , Mika Westerberg , Wolfram Sang , linux-i2c , Linux Kernel Mailing List , Lee Jones , "Wysocki, Rafael J" , "Rafael J. Wysocki" , Linux PM , Len Brown , furquan@google.com, rajatxjain@gmail.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1747 Lines: 43 On Thu, Sep 21, 2017 at 12:31 AM, Rajat Jain wrote: > Ref: https://lkml.org/lkml/2017/9/19/649 > > The intel-lpss hosts the designware i2c controller device, which > needs to be up and running until all its i2c child devices have > suspended (child devices need to be accessible over i2c until > suspend_late() has been called for all those devices). > > So lets delay the resetting of the controller until suspend_late(). > I thought of renaming function to say *_late / *_early but that > might cause confusion since the same function is also used for runtime > suspend/resume. > > Fixes: 0b471aaa0e1a ("Put I2C and SPI controllers into reset state on suspend") > Signed-off-by: Rajat Jain > --- > drivers/mfd/intel-lpss.h | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/mfd/intel-lpss.h b/drivers/mfd/intel-lpss.h > index 694116630ffa..865bbeaaf00c 100644 > --- a/drivers/mfd/intel-lpss.h > +++ b/drivers/mfd/intel-lpss.h > @@ -38,12 +38,7 @@ int intel_lpss_resume(struct device *dev); > #ifdef CONFIG_PM_SLEEP > #define INTEL_LPSS_SLEEP_PM_OPS \ > .prepare = intel_lpss_prepare, \ > - .suspend = intel_lpss_suspend, \ > - .resume = intel_lpss_resume, \ > - .freeze = intel_lpss_suspend, \ > - .thaw = intel_lpss_resume, \ > - .poweroff = intel_lpss_suspend, \ > - .restore = intel_lpss_resume, > + SET_LATE_SYSTEM_SLEEP_PM_OPS(intel_lpss_suspend, intel_lpss_resume) > #else > #define INTEL_LPSS_SLEEP_PM_OPS > #endif So I sent this exact patch several days ago: https://patchwork.kernel.org/patch/9939809/ Thanks, Rafael