Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752002AbdIUBOl (ORCPT ); Wed, 20 Sep 2017 21:14:41 -0400 Received: from mail-yw0-f172.google.com ([209.85.161.172]:51406 "EHLO mail-yw0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751821AbdIUBOi (ORCPT ); Wed, 20 Sep 2017 21:14:38 -0400 X-Google-Smtp-Source: AOwi7QBmKeihOxOELdFsjwlBNKYf7dJcwb6z8qSIjI2Kojx3afl83SXSMzKN9HZtEWcwRgOvDWHktpoqPbUX17OxAG8= MIME-Version: 1.0 In-Reply-To: References: <20170920223152.100641-1-rajatja@google.com> From: Rajat Jain Date: Wed, 20 Sep 2017 18:13:56 -0700 Message-ID: Subject: Re: [PATCH 1/2] i2c: designware: switch to suspend_late/resume_early To: "Rafael J. Wysocki" Cc: Jarkko Nikula , Andy Shevchenko , Mika Westerberg , Wolfram Sang , linux-i2c , Linux Kernel Mailing List , Lee Jones , "Wysocki, Rafael J" , "Rafael J. Wysocki" , Linux PM , Len Brown , Furquan Shaikh , Rajat Jain Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1826 Lines: 43 On Wed, Sep 20, 2017 at 5:24 PM, Rafael J. Wysocki wrote: > On Thu, Sep 21, 2017 at 12:31 AM, Rajat Jain wrote: >> Ref: https://lkml.org/lkml/2017/9/19/649 >> >> The bus controllers should suspend the bus operations only after >> all of the devices on the bus have suspended their device >> completely. Since the i2c_client drivers could be talking to >> their devices in their suspend_late() calls, lets ensure that the >> bus is alive by that time. Thus moving the controller suspend logic to >> suspend_late(). >> >> Signed-off-by: Rajat Jain >> --- >> drivers/i2c/busses/i2c-designware-platdrv.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c >> index 0e65b97842b4..66dd7f844c40 100644 >> --- a/drivers/i2c/busses/i2c-designware-platdrv.c >> +++ b/drivers/i2c/busses/i2c-designware-platdrv.c >> @@ -468,7 +468,7 @@ static int dw_i2c_plat_suspend(struct device *dev) >> static const struct dev_pm_ops dw_i2c_dev_pm_ops = { >> .prepare = dw_i2c_plat_prepare, >> .complete = dw_i2c_plat_complete, >> - SET_SYSTEM_SLEEP_PM_OPS(dw_i2c_plat_suspend, dw_i2c_plat_resume) >> + SET_LATE_SYSTEM_SLEEP_PM_OPS(dw_i2c_plat_suspend, dw_i2c_plat_resume) >> SET_RUNTIME_PM_OPS(dw_i2c_plat_runtime_suspend, >> dw_i2c_plat_resume, >> NULL) > > No, you can't just do that. > > I sent patches to do it properly before my trip to LA last week, it > shouldn't be overly difficult to find them in the mailing list > archives. I can look them up tomorrow if need be. Thanks, I am guessing you mean this? https://patchwork.kernel.org/patch/9939807/ > > Thanks, > Rafael