Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751729AbdIUGzi (ORCPT ); Thu, 21 Sep 2017 02:55:38 -0400 Received: from mail-dm3nam03on0052.outbound.protection.outlook.com ([104.47.41.52]:4848 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751450AbdIUGzg (ORCPT ); Thu, 21 Sep 2017 02:55:36 -0400 From: "Deucher, Alexander" To: "'Thomas Meyer'" , "Koenig, Christian" , "airlied@linux.ie" , "amd-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH 1/4] drm/amd/powerplay: Cocci spatch "alloc_cast" Thread-Topic: [PATCH 1/4] drm/amd/powerplay: Cocci spatch "alloc_cast" Thread-Index: AQHTMqT0+jfKsRvVN0Cc58Dkzls5YqK+582g Date: Thu, 21 Sep 2017 06:55:33 +0000 Message-ID: References: <1505975570447-826702259-0-diffsplit-thomas@m3y3r.de> <1505975570447-1553434828-1-diffsplit-thomas@m3y3r.de> In-Reply-To: <1505975570447-1553434828-1-diffsplit-thomas@m3y3r.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Deucher@amd.com; x-originating-ip: [65.223.155.30] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;BN6PR12MB1298;20:LAp0el4AgL1oZUFZFoUQUmyL93MjKDOpWU0TpcHdhfT8AUH5PRKzACNMa6NH4XMKoda1WTn3l9l/OEx3dTGC1bs8SvRsjMTG2YfhlnKOEmjn7pDM6Hvwssjkr7TfsPw3S8H0UPbYfTKhl3TztzfR3LorB/6NnA42EXd1XJZAcrc5W8RCIWm6SilqeduhcXQ6budEjGHHWbIVJ2Rl1XKCDR9U8Yy4JN9fTX7V0Gq4BSKO5kA6mq+SC+XY8B5gPUVu x-ms-exchange-antispam-srfa-diagnostics: SSOS;SSOR; x-forefront-antispam-report: SFV:SKI;SCL:-1;SFV:NSPM;SFS:(10009020)(6009001)(376002)(39860400002)(346002)(199003)(377454003)(189002)(13464003)(77096006)(2900100001)(189998001)(6506006)(6436002)(86362001)(53546010)(3280700002)(81156014)(68736007)(8676002)(33656002)(72206003)(478600001)(229853002)(81166006)(316002)(101416001)(7696004)(2950100002)(14454004)(97736004)(110136005)(5660300001)(2501003)(9686003)(106356001)(76176999)(55016002)(99286003)(2906002)(54356999)(53936002)(2201001)(25786009)(50986999)(105586002)(3660700001)(6246003)(66066001)(8936002)(6116002)(3846002)(102836003)(305945005)(74316002)(7736002);DIR:OUT;SFP:1101;SCL:1;SRVR:BN6PR12MB1298;H:BN6PR12MB1652.namprd12.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; x-ms-office365-filtering-correlation-id: e75f031b-1281-4104-92cf-08d500bdc152 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(300000502095)(300135100095)(22001)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:BN6PR12MB1298; x-ms-traffictypediagnostic: BN6PR12MB1298: x-exchange-antispam-report-test: UriScan:(9452136761055)(217544274631240); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(3002001)(10201501046)(100000703101)(100105400095)(93006095)(93001095)(6055026)(6041248)(20161123560025)(20161123558100)(20161123564025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:BN6PR12MB1298;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:BN6PR12MB1298; x-forefront-prvs: 04371797A5 spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Sep 2017 06:55:33.2838 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1298 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v8L6thw1008548 Content-Length: 3355 Lines: 105 > -----Original Message----- > From: Thomas Meyer [mailto:thomas@m3y3r.de] > Sent: Thursday, September 21, 2017 2:34 AM > To: Deucher, Alexander; Koenig, Christian; airlied@linux.ie; amd- > gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org; linux- > kernel@vger.kernel.org > Subject: [PATCH 1/4] drm/amd/powerplay: Cocci spatch "alloc_cast" > > Remove casting the values returned by memory allocation functions like > kmalloc, kzalloc, kmem_cache_alloc, kmem_cache_zalloc etc." > Found by coccinelle spatch "api/alloc/alloc_cast.cocci" > > Signed-off-by: Thomas Meyer > --- > > diff -u -p > a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_processpptables.c > b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_processpptables.c > --- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_processpptables.c > +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_processpptables.c > @@ -291,7 +291,7 @@ static int get_mm_clock_voltage_table( > table_size = sizeof(uint32_t) + > > sizeof(phm_ppt_v1_mm_clock_voltage_dependency_record) * > mm_dependency_table->ucNumEntries; > - mm_table = (phm_ppt_v1_mm_clock_voltage_dependency_table > *) > + mm_table = > kzalloc(table_size, GFP_KERNEL); Please fix up the whitespace here and below. Alex > > if (!mm_table) > @@ -519,7 +519,7 @@ static int get_socclk_voltage_dependency > > sizeof(phm_ppt_v1_clock_voltage_dependency_record) * > clk_dep_table->ucNumEntries; > > - clk_table = (phm_ppt_v1_clock_voltage_dependency_table *) > + clk_table = > kzalloc(table_size, GFP_KERNEL); > > if (!clk_table) > @@ -554,7 +554,7 @@ static int get_mclk_voltage_dependency_t > > sizeof(phm_ppt_v1_clock_voltage_dependency_record) * > mclk_dep_table->ucNumEntries; > > - mclk_table = (phm_ppt_v1_clock_voltage_dependency_table *) > + mclk_table = > kzalloc(table_size, GFP_KERNEL); > > if (!mclk_table) > @@ -596,7 +596,7 @@ static int get_gfxclk_voltage_dependency > > sizeof(phm_ppt_v1_clock_voltage_dependency_record) * > clk_dep_table->ucNumEntries; > > - clk_table = (struct phm_ppt_v1_clock_voltage_dependency_table *) > + clk_table = > kzalloc(table_size, GFP_KERNEL); > > if (!clk_table) > @@ -663,7 +663,7 @@ static int get_pix_clk_voltage_dependenc > > sizeof(phm_ppt_v1_clock_voltage_dependency_record) * > clk_dep_table->ucNumEntries; > > - clk_table = (struct phm_ppt_v1_clock_voltage_dependency_table *) > + clk_table = > kzalloc(table_size, GFP_KERNEL); > > if (!clk_table) > @@ -728,7 +728,7 @@ static int get_dcefclk_voltage_dependenc > > sizeof(phm_ppt_v1_clock_voltage_dependency_record) * > num_entries; > > - clk_table = (struct phm_ppt_v1_clock_voltage_dependency_table *) > + clk_table = > kzalloc(table_size, GFP_KERNEL); > > if (!clk_table) > @@ -772,7 +772,7 @@ static int get_pcie_table(struct pp_hwmg > sizeof(struct phm_ppt_v1_pcie_record) * > atom_pcie_table->ucNumEntries; > > - pcie_table = (struct phm_ppt_v1_pcie_table *) > + pcie_table = > kzalloc(table_size, GFP_KERNEL); > > if (!pcie_table) > @@ -1026,7 +1026,7 @@ static int get_vddc_lookup_table( > table_size = sizeof(uint32_t) + > sizeof(phm_ppt_v1_voltage_lookup_record) * > max_levels; > > - table = (phm_ppt_v1_voltage_lookup_table *) > + table = > kzalloc(table_size, GFP_KERNEL); > > if (NULL == table)