Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751773AbdIUHPz (ORCPT ); Thu, 21 Sep 2017 03:15:55 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:29209 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751485AbdIUHPz (ORCPT ); Thu, 21 Sep 2017 03:15:55 -0400 Date: Thu, 21 Sep 2017 10:15:36 +0300 From: Dan Carpenter To: Janani Sankara Babu Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, insafonov@gmail.com, mihaela.muraru21@gmail.com, goudapatilk@gmail.com, linux-kernel@vger.kernel.org, palaviv@gmail.com Subject: Re: [PATCH] staging:rtl8188eu Remove unnecessary {} braces in Message-ID: <20170921071536.visdfmkuvg2pv7sz@mwanda> References: <1505976484-28616-1-git-send-email-jananis37@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1505976484-28616-1-git-send-email-jananis37@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 677 Lines: 19 On Thu, Sep 21, 2017 at 12:18:04PM +0530, Janani Sankara Babu wrote: > --- a/drivers/staging/rtl8188eu/hal/phy.c > +++ b/drivers/staging/rtl8188eu/hal/phy.c > @@ -728,9 +728,9 @@ static void patha_fill_iqk(struct adapter *adapt, bool iqkok, s32 result[][8], > u32 oldval_0, x, tx0_a, reg; > s32 y, tx0_c; > > - if (final_candidate == 0xFF) { > + if (final_candidate == 0xFF) > return; > - } else if (iqkok) { > + else if (iqkok) { No. These ones stay. Your change would introduce a new checkpatch.pl warning if you ran it against the patched file. The rule here is that if one side of the if else has curly braces then both sides get them. regards, dan carpenter