Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751969AbdIUHfi (ORCPT ); Thu, 21 Sep 2017 03:35:38 -0400 Received: from smtp.nue.novell.com ([195.135.221.5]:33068 "EHLO smtp.nue.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751765AbdIUHff (ORCPT ); Thu, 21 Sep 2017 03:35:35 -0400 Subject: Re: [PATCH v2 18/31] scsi/aic7xxx: Clean up timer usage To: Kees Cook , Thomas Gleixner Cc: "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org References: <1505950075-50223-1-git-send-email-keescook@chromium.org> <1505950075-50223-19-git-send-email-keescook@chromium.org> From: Hannes Reinecke Message-ID: Date: Thu, 21 Sep 2017 09:35:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <1505950075-50223-19-git-send-email-keescook@chromium.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 962 Lines: 26 On 09/21/2017 01:27 AM, Kees Cook wrote: > stat_timer only ever assigns the same function and data, so consolidate to > a setup_timer() call and drop everything else used to pass things around. > > reset_timer is unused; remove it. > > Cc: Hannes Reinecke > Cc: "James E.J. Bottomley" > Cc: "Martin K. Petersen" > Cc: linux-scsi@vger.kernel.org > Signed-off-by: Kees Cook > --- > drivers/scsi/aic7xxx/aic79xx.h | 5 +---- > drivers/scsi/aic7xxx/aic79xx_core.c | 29 ++++++++--------------------- > 2 files changed, 9 insertions(+), 25 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@suse.com +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)