Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751977AbdIUI0Z (ORCPT ); Thu, 21 Sep 2017 04:26:25 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:6948 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751521AbdIUI0Y (ORCPT ); Thu, 21 Sep 2017 04:26:24 -0400 Message-ID: <59C376F8.9070209@huawei.com> Date: Thu, 21 Sep 2017 16:23:20 +0800 From: "Longpeng (Mike)" User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0) Gecko/20120327 Thunderbird/11.0.1 MIME-Version: 1.0 To: "Gonglei (Arei)" , Paolo Bonzini CC: "linux-kernel@vger.kernel.org" , "kvm@vger.kernel.org" , "Huangweidong (C)" , "wangxin (U)" , =?ISO-8859-2?Q?Radim_Kr=E8m=E1=F8?= Subject: Re: [PATCH CFT 0/4] VT-d PI fixes References: <20170606105707.23207-1-pbonzini@redhat.com> <33183CC9F5247A488A2544077AF19020DA2C98CC@DGGEMA505-MBX.china.huawei.com> <33183CC9F5247A488A2544077AF19020DA30F625@DGGEMA505-MBX.china.huawei.com> In-Reply-To: <33183CC9F5247A488A2544077AF19020DA30F625@DGGEMA505-MBX.china.huawei.com> Content-Type: text/plain; charset="ISO-8859-2" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.177.246.209] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090201.59C377AE.0119,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 2f2bd4d00529327f655a2e2f16818f8e Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1905 Lines: 73 Hi Paolo, We have backported the first three patches and have tested for about 20 days, it works fine. So could you consider to merge this series ? -- Regards, Longpeng(Mike) On 2017/7/11 17:16, Gonglei (Arei) wrote: > > >> -----Original Message----- >> From: kvm-owner@vger.kernel.org [mailto:kvm-owner@vger.kernel.org] On >> Behalf Of Paolo Bonzini >> Sent: Tuesday, July 11, 2017 4:56 PM >> To: Gonglei (Arei) >> Cc: linux-kernel@vger.kernel.org; kvm@vger.kernel.org; longpeng; >> Huangweidong (C); wangxin (U); Radim Kr?m?? >> Subject: Re: [PATCH CFT 0/4] VT-d PI fixes >> >> On 07/06/2017 11:33, Gonglei (Arei) wrote: >>> We are testing your patch, but maybe need some time to report >>> the results because it's not an inevitable problem. >>> >>> Meanwhile we also try to find a possible scenario of non-hotplugging to >>> explain the double-add warnings. >> >> Hi Lei, >> >> do you have any updates? > > Dear Paolo, > > Thanks for kicking me :) > > TBH, thinking about the reliability of productive project (we use kvm-4.4), > we applied the patch you used in fedora pastebin, and > the bug seems gone after one month's testing. > > diff --git a/source/x86/vmx.c b/source/x86/vmx.c > index 79012cf..efc611f 100644 > --- a/source/x86/vmx.c > +++ b/source/x86/vmx.c > @@ -11036,8 +11036,9 @@ static void pi_post_block(struct kvm_vcpu *vcpu) > unsigned int dest; > unsigned long flags; > > - if (!kvm_arch_has_assigned_device(vcpu->kvm) || > - !irq_remapping_cap(IRQ_POSTING_CAP)) > + if ((vcpu->pre_pcpu == -1) && > + (!kvm_arch_has_assigned_device(vcpu->kvm) || > + !irq_remapping_cap(IRQ_POSTING_CAP))) > return; > >> I would like to get at least the first three >> patches in 4.13. >> > I think they are okay to me for upstream. > > Thanks, > -Gonglei > > . > -- Regards, Longpeng(Mike)