Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751734AbdIUJue (ORCPT ); Thu, 21 Sep 2017 05:50:34 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:7831 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751521AbdIUJuc (ORCPT ); Thu, 21 Sep 2017 05:50:32 -0400 X-UUID: 130ece11292f4b1a9c72a96f557de6bb-20170921 Message-ID: <1505987424.3084.8.camel@mtkswgap22> Subject: Re: [PATCH v1 3/4] arm: dts: mt7623: add display related nodes From: Ryder Lee To: CK Hu CC: Matthias Brugger , , Linus Walleij , , , Date: Thu, 21 Sep 2017 17:50:24 +0800 In-Reply-To: <1505834813.16414.5.camel@mtksdaap41> References: <0eb19ae1a4717d316cdaec44f6c20bfa8aa24ddc.1505801355.git.ryder.lee@mediatek.com> <1505834813.16414.5.camel@mtksdaap41> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2705 Lines: 90 On Tue, 2017-09-19 at 23:26 +0800, CK Hu wrote: > Hi, Ryder: > > Some comment inline. > > On Tue, 2017-09-19 at 14:27 +0800, Ryder Lee wrote: > > This patch adds the device nodes for the display function block. > > Also, we add some missing pin macros in mt7623-pinfunc.h. > > > > Signed-off-by: Ryder Lee > > CC: Linus Walleij > > Acked-by: Linus Walleij > > --- > > arch/arm/boot/dts/mt7623.dtsi | 210 ++++++++++++++++++++++++++ > > arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts | 41 ++++- > > include/dt-bindings/pinctrl/mt7623-pinfunc.h | 12 ++ > > 3 files changed, 261 insertions(+), 2 deletions(-) > > > > diff --git a/arch/arm/boot/dts/mt7623.dtsi b/arch/arm/boot/dts/mt7623.dtsi > > index 9ec3767..e11e5e7 100644 > > --- a/arch/arm/boot/dts/mt7623.dtsi > > +++ b/arch/arm/boot/dts/mt7623.dtsi > > @@ -20,6 +20,7 @@ > > #include > > #include > > #include > > +#include > > #include > > #include > > #include "skeleton64.dtsi" > > @@ -28,6 +29,11 @@ > > compatible = "mediatek,mt7623"; > > interrupt-parent = <&sysirq>; > > > > + aliases { > > + rdma0 = &rdma0; > > + rdma1 = &rdma1; > > For display, are these two aliases enough? Yes, this part is the same as mt2701. https://patchwork.kernel.org/patch/9803813/ > > + }; > > + ... > > + wdma@14009000 { > > + compatible = "mediatek,mt7623-disp-wdma", > > + "mediatek,mt2701-disp-wdma"; > > There is neither "mediatek,mt7623-disp-wdma" nor > "mediatek,mt2701-disp-wdma" in driver, do you really need this device > node? Okay, I will remove it. > > + reg = <0 0x14009000 0 0x1000>; > > + interrupts = ; > > + clocks = <&mmsys CLK_MM_DISP_WDMA>; > > + iommus = <&iommu MT2701_M4U_PORT_DISP_WDMA>; > > + mediatek,larb = <&larb0>; > > + }; > > + > > + bls: bls@1400a000 { > > + compatible = "mediatek,mt7623-disp-pwm", > > + "mediatek,mt2701-disp-pwm"; > > + reg = <0 0x1400a000 0 0x1000>; > > + #pwm-cells = <2>; > > + clocks = <&mmsys CLK_MM_MDP_BLS_26M>, > > + <&mmsys CLK_MM_DISP_BLS>; > > + clock-names = "main", "mm"; > > + status = "disabled"; > > + }; > > + > > + color@1400b000 { > > color: color@1400b000 { Okay. > > + compatible = "mediatek,mt7623-disp-color", > > + "mediatek,mt2701-disp-color"; > > + reg = <0 0x1400b000 0 0x1000>; > > + interrupts = ; > > + clocks = <&mmsys CLK_MM_DISP_COLOR>; > > + }; > > +