Message-ID: <1505989440.12311.22.camel@perches.com>
Subject: Re: [PATCH] staging:rtl8188eu Remove unnecessary {} braces in
From: Joe Perches <joe@perches.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
        Janani Sankara Babu <jananis37@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
        insafonov@gmail.com, mihaela.muraru21@gmail.com, goudapatilk@gmail.com,
        linux-kernel@vger.kernel.org, palaviv@gmail.com
Date: Thu, 21 Sep 2017 03:24:00 -0700
In-Reply-To: <20170921071536.visdfmkuvg2pv7sz@mwanda>
References: <1505976484-28616-1-git-send-email-jananis37@gmail.com>
         <20170921071536.visdfmkuvg2pv7sz@mwanda>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1062
Lines: 42

On Thu, 2017-09-21 at 10:15 +0300, Dan Carpenter wrote:
> On Thu, Sep 21, 2017 at 12:18:04PM +0530, Janani Sankara Babu wrote:
> > --- a/drivers/staging/rtl8188eu/hal/phy.c
> > +++ b/drivers/staging/rtl8188eu/hal/phy.c
> > @@ -728,9 +728,9 @@ static void patha_fill_iqk(struct adapter *adapt, bool iqkok, s32 result[][8],
> >  	u32 oldval_0, x, tx0_a, reg;
> >  	s32 y, tx0_c;
> >  
> > -	if (final_candidate == 0xFF) {
> > +	if (final_candidate == 0xFF)
> >  		return;
> > -	} else if (iqkok) {
> > +	else if (iqkok) {
> 
> No.  These ones stay.  Your change would introduce a new checkpatch.pl
> warning if you ran it against the patched file.  The rule here is that
> if one side of the if else has curly braces then both sides get them.

And the else could be removed

	if (final_candidate == 0xff)
		return;

	if (iqkok) {
		[etc...]

and the code should probably be

	if (final_candidate == 0xff)
		return;

	if (!iqkok)
		return;

	[unindented etc...]

or combine the first 2 tests

	if (final_candidate == 0xff || !iqkok)
		return;

	[unindented etc...]