Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751808AbdIULMV (ORCPT ); Thu, 21 Sep 2017 07:12:21 -0400 Received: from lelnx193.ext.ti.com ([198.47.27.77]:55651 "EHLO lelnx193.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751550AbdIULMT (ORCPT ); Thu, 21 Sep 2017 07:12:19 -0400 Subject: Re: [PATCH 1/3] ASoC: davinci-mcasp: Handle return value of devm_kasprintf To: Arvind Yadav , , , , , , , , , , References: <1505901971-12004-1-git-send-email-arvind.yadav.cs@gmail.com> <1505901971-12004-2-git-send-email-arvind.yadav.cs@gmail.com> CC: , From: Peter Ujfalusi Message-ID: <2fcb7f93-0449-118a-aa8d-4de51ee39895@ti.com> Date: Thu, 21 Sep 2017 14:11:54 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1505901971-12004-2-git-send-email-arvind.yadav.cs@gmail.com> Content-Type: text/plain; charset="utf-8" X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v8LBCOw8025804 Content-Length: 1897 Lines: 54  Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki On 2017-09-20 13:06, Arvind Yadav wrote: > devm_kasprintf() can fail here and we must check its return value. Acked-by: Peter Ujfalusi > Signed-off-by: Arvind Yadav > --- > sound/soc/davinci/davinci-mcasp.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/sound/soc/davinci/davinci-mcasp.c b/sound/soc/davinci/davinci-mcasp.c > index f395bbc..d1a4aa2 100644 > --- a/sound/soc/davinci/davinci-mcasp.c > +++ b/sound/soc/davinci/davinci-mcasp.c > @@ -1867,6 +1867,10 @@ static int davinci_mcasp_probe(struct platform_device *pdev) > if (irq >= 0) { > irq_name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "%s_common", > dev_name(&pdev->dev)); > + if (!irq_name) { > + ret = -ENOMEM; > + goto err; > + } > ret = devm_request_threaded_irq(&pdev->dev, irq, NULL, > davinci_mcasp_common_irq_handler, > IRQF_ONESHOT | IRQF_SHARED, > @@ -1884,6 +1888,10 @@ static int davinci_mcasp_probe(struct platform_device *pdev) > if (irq >= 0) { > irq_name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "%s_rx", > dev_name(&pdev->dev)); > + if (!irq_name) { > + ret = -ENOMEM; > + goto err; > + } > ret = devm_request_threaded_irq(&pdev->dev, irq, NULL, > davinci_mcasp_rx_irq_handler, > IRQF_ONESHOT, irq_name, mcasp); > @@ -1899,6 +1907,10 @@ static int davinci_mcasp_probe(struct platform_device *pdev) > if (irq >= 0) { > irq_name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "%s_tx", > dev_name(&pdev->dev)); > + if (!irq_name) { > + ret = -ENOMEM; > + goto err; > + } > ret = devm_request_threaded_irq(&pdev->dev, irq, NULL, > davinci_mcasp_tx_irq_handler, > IRQF_ONESHOT, irq_name, mcasp); > - Péter