Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751832AbdIULhT (ORCPT ); Thu, 21 Sep 2017 07:37:19 -0400 Received: from mail-io0-f181.google.com ([209.85.223.181]:50335 "EHLO mail-io0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751765AbdIULhR (ORCPT ); Thu, 21 Sep 2017 07:37:17 -0400 X-Google-Smtp-Source: AOwi7QBb8wcm92qEHY+dnP2B2LrjrWXCY8rrAjZUiuMWcxYgShiX2O6yIM9KHQTCAgNmQEytMtf7htG2kCdq1BN1JlA= MIME-Version: 1.0 In-Reply-To: <20170913161501.7356-1-colin.king@canonical.com> References: <20170913161501.7356-1-colin.king@canonical.com> From: Linus Walleij Date: Thu, 21 Sep 2017 13:37:16 +0200 Message-ID: Subject: Re: [PATCH][pinctrl-next] pinctrl/amd: make functions amd_gpio_suspend and amd_gpio_resume static To: Colin King Cc: "linux-gpio@vger.kernel.org" , Daniel Drake , kernel-janitors@vger.kernel.org, "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 558 Lines: 17 On Wed, Sep 13, 2017 at 6:15 PM, Colin King wrote: > From: Colin Ian King > > The functions amd_gpio_suspend and amd_gpio_resume are local to the > source and do not need to be in global scope, so make them static. > > Cleans up sparse warnings: > symbol 'amd_gpio_suspend' was not declared. Should it be static? > symbol 'amd_gpio_resume' was not declared. Should it be static? > > Signed-off-by: Colin Ian King Patch applied with Daniel's review tag. Yours, Linus Walleij