Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751714AbdIUMCn (ORCPT ); Thu, 21 Sep 2017 08:02:43 -0400 Received: from mail-io0-f170.google.com ([209.85.223.170]:54999 "EHLO mail-io0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751593AbdIUMCk (ORCPT ); Thu, 21 Sep 2017 08:02:40 -0400 X-Google-Smtp-Source: AOwi7QBFmGOkdUXBmBMxBRRL06XwoK7wzNE9H2GO94Qoni/OVmSz6pQ1sfrVxzzlGOROnuIBr9rYxxlZUFR85lFgHzo= MIME-Version: 1.0 In-Reply-To: <20170916204234.725130-1-arnd@arndb.de> References: <20170916204234.725130-1-arnd@arndb.de> From: Linus Walleij Date: Thu, 21 Sep 2017 14:02:39 +0200 Message-ID: Subject: Re: [PATCH] gpio: omap: omap_gpio_show_rev is not __init To: Arnd Bergmann Cc: Grygorii Strashko , Santosh Shilimkar , Kevin Hilman , Linux-OMAP , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 741 Lines: 20 On Sat, Sep 16, 2017 at 10:42 PM, Arnd Bergmann wrote: > The probe function calls omap_gpio_show_rev(), which on most > compilers is inlined, but on the old gcc-4.6 is not, causing > a valid warning about the incorrect __init annotation: > > WARNING: vmlinux.o(.text+0x40f614): Section mismatch in reference from the function omap_gpio_probe() to the function .init.text:omap_gpio_show_rev() > The function omap_gpio_probe() references > the function __init omap_gpio_show_rev(). > This is often because omap_gpio_probe lacks a __init > annotation or the annotation of omap_gpio_show_rev is wrong. > > This removes the __init. > > Signed-off-by: Arnd Bergmann Patch applied for fixes. Yours, Linus Walleij