Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751617AbdIUMNo (ORCPT ); Thu, 21 Sep 2017 08:13:44 -0400 Received: from mail-it0-f53.google.com ([209.85.214.53]:46075 "EHLO mail-it0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751550AbdIUMNm (ORCPT ); Thu, 21 Sep 2017 08:13:42 -0400 X-Google-Smtp-Source: AOwi7QA5jIjMoE4nsICxx9bQVTrxNh0AtLr3SGKrudVbMkJe8aWHHx2Gvxalo41gpLTKwZg3h6MJrOIg7wqZ29yqcEk= MIME-Version: 1.0 In-Reply-To: <1cfed20c00d642a34d8f93c5e9591412d387fa2a.1505970542.git.arvind.yadav.cs@gmail.com> References: <1cfed20c00d642a34d8f93c5e9591412d387fa2a.1505970542.git.arvind.yadav.cs@gmail.com> From: Linus Walleij Date: Thu, 21 Sep 2017 14:13:41 +0200 Message-ID: Subject: Re: [PATCH v2 1/2] gpio: brcmstb: Handle return value of devm_kasprintf To: Arvind Yadav Cc: Gregory Fong , Brian Norris , Florian Fainelli , bcm-kernel-feedback-list , "linux-gpio@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 320 Lines: 13 On Thu, Sep 21, 2017 at 7:14 AM, Arvind Yadav wrote: > devm_kasprintf() can fail here and we must check its return value. > > Signed-off-by: Arvind Yadav > --- > changes in v2 : > Set return 'err' to -ENOMEM. Patch applied. Yours, Linus Walleij