Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751745AbdIUMRZ (ORCPT <rfc822;w@1wt.eu>);
        Thu, 21 Sep 2017 08:17:25 -0400
Received: from mail-io0-f170.google.com ([209.85.223.170]:44289 "EHLO
        mail-io0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751640AbdIUMRX (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 21 Sep 2017 08:17:23 -0400
X-Google-Smtp-Source: AOwi7QALbCjPQW6/XuogLGQ96SP75gdvVD+Qm4TdG8/j9OY1T8ZwFnNb96K4XiKeNZ5PCjpQYD0L9o9lC71/xg1RWDg=
MIME-Version: 1.0
In-Reply-To: <1505981592.22452.7.camel@mhfsdcap03>
References: <1501489333-23145-1-git-send-email-zhiyong.tao@mediatek.com>
 <1501489333-23145-3-git-send-email-zhiyong.tao@mediatek.com>
 <2f883a8a-5402-5625-bada-bcfed53c098e@gmail.com> <CACRpkdZHyXec+L8ueRHOs=9TLT1Arqe3KeQpRZ6D0K1Ag1c+Zw@mail.gmail.com>
 <1505981592.22452.7.camel@mhfsdcap03>
From: Linus Walleij <linus.walleij@linaro.org>
Date: Thu, 21 Sep 2017 14:17:21 +0200
Message-ID: <CACRpkdaX0n7BZVkXYFEh_XSN3P7huvhE6j5My=p=2Lh45oFZaQ@mail.gmail.com>
Subject: Re: [PATCH 2/3] arm64: dts: mt2712: add pintcrl device node.
To: Zhiyong Tao <zhiyong.tao@mediatek.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
        Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>,
        srv_heupstream@mediatek.com, Liguo Zhang <liguo.zhang@mediatek.com>,
        "Joe.C" <yingjoe.chen@mediatek.com>, hongkun.cao@mediatek.com,
        Biao Huang <biao.huang@mediatek.com>, YT Shen <yt.shen@mediatek.com>,
        Hongzhou Yang <hongzhou.yang@mediatek.com>,
        Erin Lo <erin.lo@mediatek.com>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@lists.infradead.org>,
        "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1304
Lines: 40

On Thu, Sep 21, 2017 at 10:13 AM, Zhiyong Tao <zhiyong.tao@mediatek.com> wrote:
> On Tue, 2017-08-22 at 15:04 +0200, Linus Walleij wrote:
>> On Mon, Aug 14, 2017 at 5:23 PM, Matthias Brugger
>> <matthias.bgg@gmail.com> wrote:
>> > On 07/31/2017 10:22 AM, Zhiyong Tao wrote:
>> >>
>> >> The commit includes two change:
>> >> 1)add pintcrl device node for mt2712.
>> >> 2)add pinfunc file for mt2712.
>> >>
>> >> Signed-off-by: Zhiyong Tao <zhiyong.tao@mediatek.com>
>> >> ---
>> >>   arch/arm64/boot/dts/mediatek/mt2712-pinfunc.h | 1014
>> >> +++++++++++++++++++++++++
>> >
>> >
>> > Shouldn't this file be in include/dt-bindings/pinctrl?
>>
>> Only if it is also #included in the driver.
>>
>> Yours,
>> Linus Walleij
>
> ==>
> Thanks for your comment.
> We see our some ICs(mt7623) which move the file to
> "include/dt-bindings/pinctrl". other ICs(mt2701) which is put in
> "arch/arm64/boot/dts/mediatek".
> In mt2712, mt2712-pinfunc.h is only include by dts file. It won't be
> included by driver. So which is better? "arch/arm64/boot/dts/mediatek/"
> or "include/dt-bindings/pinctrl".

If it is used in both arm and arm64 it is helpful to have it in
include/dt-bindings so it can be shared between the two
archs.

If it is just (ever) for arm64 it can stay inside the arch tree.

Yours,
Linus Walleij