Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751581AbdIUNOb (ORCPT ); Thu, 21 Sep 2017 09:14:31 -0400 Received: from mail-io0-f195.google.com ([209.85.223.195]:35678 "EHLO mail-io0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751737AbdIUNO3 (ORCPT ); Thu, 21 Sep 2017 09:14:29 -0400 X-Google-Smtp-Source: AOwi7QByj6NpIRlhiuKKiow12Jzu5Kj4WovdywmZ5XsH62NdB9aspno4WqcSH8apAZiW6TrkH47Q5NcW1VJYxlmh/gs= MIME-Version: 1.0 In-Reply-To: References: From: Arnd Bergmann Date: Thu, 21 Sep 2017 15:14:28 +0200 X-Google-Sender-Auth: 9a6YG4aDIXKsukVh0R09y1VwxzY Message-ID: Subject: Re: [RFC PATCH 5/7] sound: core: Avoid using timespec for struct snd_timer_status To: Baolin Wang Cc: Jaroslav Kysela , Takashi Iwai , Liam Girdwood , Ingo Molnar , Takashi Sakamoto , SF Markus Elfring , Dan Carpenter , jeeja.kp@intel.com, Vinod Koul , dharageswari.r@intel.com, guneshwor.o.singh@intel.com, Bhumika Goyal , gudishax.kranthikumar@intel.com, Naveen M , hardik.t.shah@intel.com, Arvind Yadav , fabf@skynet.be, Mark Brown , Deepa Dinamani , alsa-devel@alsa-project.org, Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1239 Lines: 27 On Thu, Sep 21, 2017 at 8:18 AM, Baolin Wang wrote: > static long snd_timer_user_ioctl_compat(struct file *file, unsigned int cmd, unsigned long arg) > @@ -158,12 +151,10 @@ static long snd_timer_user_ioctl_compat(struct file *file, unsigned int cmd, uns > return snd_timer_user_gparams_compat(file, argp); > case SNDRV_TIMER_IOCTL_INFO32: > return snd_timer_user_info_compat(file, argp); > - case SNDRV_TIMER_IOCTL_STATUS32: > + case SNDRV_TIMER_IOCTL_STATUS_COMPAT32: > return snd_timer_user_status_compat(file, argp); > -#ifdef CONFIG_X86_X32 > - case SNDRV_TIMER_IOCTL_STATUS_X32: > - return snd_timer_user_status_x32(file, argp); > -#endif /* CONFIG_X86_X32 */ > + case SNDRV_TIMER_IOCTL_STATUS_COMPAT64: > + return snd_timer_user_status64(file, argp); > } I think the last line would fail to build since snd_timer_user_status64() is defined 'static' in a different file. Also, snd_timer_user_status_compat() seems to be the same as snd_timer_user_status32(), so I think you can redirect it the same way as snd_timer_user_status64 after making both functions globally visible. Arnd