Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751748AbdIUO7d (ORCPT ); Thu, 21 Sep 2017 10:59:33 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:56638 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751598AbdIUO7c (ORCPT ); Thu, 21 Sep 2017 10:59:32 -0400 Date: Thu, 21 Sep 2017 07:59:30 -0700 From: Christoph Hellwig To: Jens Axboe Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, hannes@cmpxchg.org, clm@fb.com, jack@suse.cz Subject: Re: [PATCH 4/7] page-writeback: pass in '0' for nr_pages writeback in laptop mode Message-ID: <20170921145929.GD8839@infradead.org> References: <1505921582-26709-1-git-send-email-axboe@kernel.dk> <1505921582-26709-5-git-send-email-axboe@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1505921582-26709-5-git-send-email-axboe@kernel.dk> User-Agent: Mutt/1.8.3 (2017-05-23) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 713 Lines: 18 On Wed, Sep 20, 2017 at 09:32:59AM -0600, Jens Axboe wrote: > Laptop mode really wants to writeback the number of dirty > pages and inodes. Instead of calculating this in the caller, > just pass in 0 and let wakeup_flusher_threads() handle it. > > Use the new wakeup_flusher_threads_bdi() instead of rolling > our own. This changes the writeback to not be range cyclic, > but that should not matter for laptop mode flush-all > semantics. Looks good, Reviewed-by: Christoph Hellwig While we're at sorting out the laptop_mode_wb_timer mess: can we move initializing and deleting it from the block code to the backing-dev code given that it now doesn't assume anything about block devices any more?