Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751873AbdIUPFW (ORCPT <rfc822;w@1wt.eu>);
        Thu, 21 Sep 2017 11:05:22 -0400
Received: from sabertooth02.qualcomm.com ([65.197.215.38]:41588 "EHLO
        sabertooth02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751793AbdIUPFU (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 21 Sep 2017 11:05:20 -0400
X-IronPort-AV: E=Sophos;i="5.42,425,1500966000"; 
   d="scan'208";a="116084477"
X-IronPort-AV: E=McAfee;i="5900,7806,8660"; a="1427748160"
X-MGA-submission: =?us-ascii?q?MDGervkvrJeRIzjwOchRKGFXTB4Y3jYWMvDG+7?=
 =?us-ascii?q?BpTDnR38V09gg17t5UqpNR3H7XcuuOpr+M8/hNZ5lcuZX8bBbW/jYnyD?=
 =?us-ascii?q?rihS9TPdebVM+sZnWA3BaoHz90972JaZvmIC05eOWU3dbxfcljKmOOQL?=
 =?us-ascii?q?wG?=
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Arnd Bergmann <arnd@arndb.de>
CC: Govind Singh <govinds@qti.qualcomm.com>,
        Ryan Hsu <ryanhsu@qti.qualcomm.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        Rajkumar Manoharan <rmanohar@qti.qualcomm.com>,
        "ath10k@lists.infradead.org" <ath10k@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
        Colin Ian King <colin.king@canonical.com>,
        Ben Greear <greearb@candelatech.com>,
        Ashok Raj Nagarajan <arnagara@qti.qualcomm.com>,
        "bartosz.markowski@tieto.com" <bartosz.markowski@tieto.com>
Subject: Re: [PATCH] ath10: mark PM functions as __maybe_unused
Thread-Topic: [PATCH] ath10: mark PM functions as __maybe_unused
Thread-Index: AQHTJ84nQlu/+469V0SQ92Z6DQDMsA==
Date: Thu, 21 Sep 2017 15:05:15 +0000
Message-ID: <87poak853p.fsf@kamboji.qca.qualcomm.com>
References: <20170906125904.2588620-1-arnd@arndb.de>
In-Reply-To: <20170906125904.2588620-1-arnd@arndb.de> (Arnd Bergmann's message
        of "Wed, 6 Sep 2017 14:58:53 +0200")
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.251.52.12]
Content-Type: text/plain; charset="iso-8859-1"
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v8LF5QTb010936
Content-Length: 893
Lines: 23

Arnd Bergmann <arnd@arndb.de> writes:

> When CONFIG_PM_SLEEP is disabled, we get a compile-time
> warning:
>
> drivers/net/wireless/ath/ath10k/pci.c:3417:12: error: 'ath10k_pci_pm_resume' defined but not used [-Werror=unused-function]
>  static int ath10k_pci_pm_resume(struct device *dev)
>             ^~~~~~~~~~~~~~~~~~~~
> drivers/net/wireless/ath/ath10k/pci.c:3401:12: error: 'ath10k_pci_pm_suspend' defined but not used [-Werror=unused-function]
>  static int ath10k_pci_pm_suspend(struct device *dev)
>
> Rather than fixing the #ifdef, this just marks both functions
> as __maybe_unused, which is a more robust way to do this.
>
> Fixes: 32faa3f0ee50 ("ath10k: add the PCI PM core suspend/resume ops")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Applied to ath-current branch in ath.git, thanks.

(Having problems with my patchwork script so sending this manually)

-- 
Kalle Valo